[samsungtv] Exception thrown when changing input source on legacy TV about openhab-addons HOT 8 CLOSED

Ok,

I found the issue. In the original binding, the duplicate key simply overwrote the first key. In the new version I am using a stream to generate the Map, which throws the "duplicate key" exception.

Fortunately the toMap() function has a method for dealing with duplicate keys (which I had not implemented), so it's an easy fix.

from openhab-addons.

@NickWaterton - FYI, it seems I'm experiencing a regression here when trying to switch source on a legacy TV.

from openhab-addons.

It looks like you may have two inputs on the TV both called HDMI-CEC. Can you list the inputs on your TV (on the screen), take a picture and post it here?

The binding queries the source list, and ID's and fills a variable Map<String, String> - and it looks like you have a duplicate source name. This is the same as the old binding though, so not sure what is different.

Thanks,

from openhab-addons.

It looks like you may have two inputs on the TV both called HDMI-CEC. Can you list the inputs on your TV (on the screen), take a picture and post it here?

Yes, indeed, you are right:

from openhab-addons.

Fortunately I have one of these legacy TV's as well, with one HDMI-CEC device. I will have to think about how to deal with this situation.

from openhab-addons.

@jlaur

Can you try this jar if it fixes the issue, I'll issue a PR.

Thanks.

from openhab-addons.

Can you try this jar if it fixes the issue, I'll issue a PR.

Sure, thanks! Perhaps you can already create the PR and add label "additional testing preferred"? I can then backport the fix and test it on my production system in the evening - and perform a review as well?

from openhab-addons.

Can you try this jar if it fixes the issue, I'll issue a PR.

Sure, thanks! Perhaps you can already create the PR and add label "additional testing preferred"? I can then backport the fix and test it on my production system in the evening - and perform a review as well?

PR #16787 created, I don't seem to be able to add labels though.

from openhab-addons.