Giter VIP home page Giter VIP logo

Comments (3)

adymorz avatar adymorz commented on August 26, 2024

Summary

I got the same error on my installation.

I am using SimpleSAMLphp Version 1.15.0 and current master from https://github.com/simplesamlphp/simplesamlphp-module-openidprovider, installed using composer. It loaded openid/php-openid Version 2.3.0.

Analysis

The problem is the following code in function processRequest in modules/openidProvider/lib/Server.php, which tries to acces the private property identity on an instance of Auth_OpenID_CheckIDRequest:

		if (!$request->idSelect() && $identity !== $request->identity) {
			/* The identity in the request doesn't match the one of the logged in user. */
			throw new SimpleSAML_Error_Exception('Logged in as different user than the one requested.');
		}

Quickfix

Replace the code in modules/openidProvider/lib/Server.php:

		if (!$request->idSelect() && $identity !== $request->identity) {

with

		if (!$request->idSelect() && $identity !== $request->getIdentity()) {

Add the following code in class Auth_OpenID_CheckIDRequest in vendor/openid/php-openid/Auth/OpenID/Server.php:

    /**
     * @return string
     */
    public function getIdentity()
    {
        return $this->identity;
    }

from php-openid.

adymorz avatar adymorz commented on August 26, 2024

This issue has been introduced in #136

I just create a pull request containing an easy fix for the issue. I know that the property would be private in a perfect world and access would happen through a getter method. To prevent adjustments in both libraries I went for the easy fix.

from php-openid.

adymorz avatar adymorz commented on August 26, 2024

Thank you!

from php-openid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.