Comments (5)
zandbelt
commented on August 15, 2024
I agree: time to change to jansson; stay tuned.
from mod_auth_openidc.
zandbelt
commented on August 15, 2024
here we go: please check 2a187ee
from mod_auth_openidc.
martinsrom
commented on August 15, 2024
Thank you for the quick change to jansson.
But the code is still not completely correct, because integers in JSON are rendered as %ld into claims instead of their values.
I suspect that apr_psprintf method is not properly handling the %lld format (into which the JSON_INTEGER_FORMAT is expanded).
I tried to change the
apr_psprintf(r->pool, "%" JSON_INTEGER_FORMAT "", json_integer_value(j_value)),
to
apr_psprintf(r->pool, "%ld", json_integer_value(j_value)),
and it fixes the problem (but it produces a compilation warning).
May be the final solution would be to explicitly cast the result from json_integer_value to long int:
apr_psprintf(r->pool, "%ld", (long int) json_integer_value(j_value)),
from mod_auth_openidc.
zandbelt
commented on August 15, 2024
apparently Mac OS X did not suffer from this; fixed by using plain sprintf in 2745e10
from mod_auth_openidc.
martinsrom
commented on August 15, 2024
The JSON processing now seems correct, thank you for fixes.
from mod_auth_openidc.
Related Issues (20)
- OIDC Session decoding fails when OIDCSessionType client-cookie
- oidc_cache_mutex_lock: apr_global_mutex_lock() failed: Permission Denied (13) HOT 1
- Apache2 OIDC and reverse proxy for tomcat application HOT 1
- oidc_refresh_access_token_before_expiry? HOT 3
- Add support for exp and iat on Request Object
- Custom User-Agent header and/or other headers for back-channel request
- Metrics Parsing Error with Prometheus Input Plugin for Telegraf
- Unauthorized action returns 404 error code instead of 401 HOT 1
- Compile error with release 2.4.15.4 if libhiredis-dev is not installed
- Internal Server Error happens with release 2.4.15.5 and timed out sessions HOT 2
- Enabling Metrics Endpoint causes Segmentation Faults during Shutdown
- Checking for dead memcache server buggy? HOT 1
- Backchannel logout stopped working with file-based cache
- Claim header values are encoded in UTF-8 character set as opposed to ISO-8859-1 character set HOT 1
- Build does not support openssl-3 HOT 1
- Generic Multiple Provider in 1 Apache server instance HOT 1
- oidc_cache_set: could NOT store 797 bytes in shm cache backend for key HOT 1
- id_token_hint is missing on logout redirect HOT 1
- support for EdDSA HOT 1
- Support for Resource Owner Password Credentials flow HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mod_auth_openidc.