Giter VIP home page Giter VIP logo

Comments (6)

ashauer avatar ashauer commented on May 30, 2024 1

No need to do anything in oih-data-record.json as they already were there yesterday...

from data-and-domain-models.

hschmidthh avatar hschmidthh commented on May 30, 2024 1

fixed wrong attribute naming

from data-and-domain-models.

hschmidthh avatar hschmidthh commented on May 30, 2024

For the address model they are self explanatory and i think this will clutter the model.

from data-and-domain-models.

RaphaelKomander avatar RaphaelKomander commented on May 30, 2024

This is an excerpt - as one concrete example - from shared-definitions.json (line 42).

"Social": {
	"type": "object",
	"properties": {
		"eMail": { "type": "string" }
	}
},

An "eMail" as property is might be confusing at this point - no relation towards a specific network.

"Social": {
	"type": "object",
	"properties": {
		"network" : {
			"type" : "string",
			"description": "Provision name of social network"
		},
		"id": { 
			"type": "string",
			"description": "Provision social network ID"
		}
},

Could this be an self explaining approach - for mapping?

from data-and-domain-models.

ashauer avatar ashauer commented on May 30, 2024

Don't see the need to add documentation to a sample model which should not even be taken really serious. It's just a sample to introduce concepts...

from data-and-domain-models.

RaphaelKomander avatar RaphaelKomander commented on May 30, 2024

Just kept this for the sake to remember for upcoming Epics #50

from data-and-domain-models.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.