Giter VIP home page Giter VIP logo

Comments (7)

labarba avatar labarba commented on June 21, 2024

This is two tasks:

  1. adding the drop-down "Submission Type" to the web form (easy task)
  2. modifying whedon so it knows which review checklist to print on the "Review" issue (not so easy?)

Perhaps task 2 can be made easier by delegating to the editor that commands whedon to start the review with choosing the submission type. Something like:

@whedon start review -type oer magic-word=bananas
vs
@whedon start review -type tool magic-word=bananas

Leaves a margin for human error, but a minor risk I think.

from jose-old.

labarba avatar labarba commented on June 21, 2024

@arfon Care to comment on this?

from jose-old.

arfon avatar arfon commented on June 21, 2024

@arfonย Care to comment on this?

Sure thing. I don't think Whedon needs to know anything about this as the review checklist is actually described in the JOSS (or JOSE in this case) we application: https://github.com/openjournals/jose/blob/master/app/views/shared/review_body.erb

So we need to adapt the database schema to add a submission_type field to thepapers table. Then we can add some view logic to allow people to pick which type of material they're submitting.

When the editor starts the review (@whedon start review) we can just have a case statement in the review_body.erb to make sure the correct review body is written to the GitHub issue.

Edit: Do you have someone to make these changes?

from jose-old.

labarba avatar labarba commented on June 21, 2024

Ah, much better!

from jose-old.

moorepants avatar moorepants commented on June 21, 2024

Do you have someone to make these changes?

I think we need an editor that knows Ruby...

from jose-old.

labarba avatar labarba commented on June 21, 2024

@arfon : We do not have anyone on hand to make these changes.

from jose-old.

labarba avatar labarba commented on June 21, 2024

This was completed as part of the whedon upgrade. See:
openjournals/joss#329

from jose-old.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.