Comments (36)
Ok then I think we're done here. Congrats @glouppe and @cranmer on our first accepted paper!
I'll finish up the editorial pieces this evening.
🚀
from joss-reviews.
This is now accepted and live on JOSS!
from joss-reviews.
Compare https://github.com/openjournals/joss-papers/blob/master/joss.00011/10.21105.joss.00011.pdf (from the journal page) to the last PDF you posted in this issue. The only reference in the PDF has a link to the arxiv in the version you posted here but not in the journal version
from joss-reviews.
Hi @glouppe. Many thanks for submitting to JOSS!
The next step is to look for a couple of reviewers - if you have any suggestions please add them here. 🚀
@jakevdp - this do you have any suggestions?
from joss-reviews.
from joss-reviews.
Compiled paper PDF: paper.pdf
from joss-reviews.
Thanks @whedon would be nice if arxiv showed up in bib. should we edit bib or change style for latex?
from joss-reviews.
@cranmer This is the command that we're running to compile from Markdown to PDF: https://github.com/openjournals/whedon/blob/master/lib/whedon/processor.rb#L64 and this is the latex template: https://github.com/openjournals/whedon/blob/master/resources/latex.template
Any suggestions/modifications that would make arXiv show up very welcome 😄
from joss-reviews.
As a reviewer should I do things beyond what is listed in the initial comment on this PR or is that it? If it is only those questions I can review this and use this opportunity to declare that I am a good friend of @glouppe but don't think this creates a conflict of interest.
from joss-reviews.
If it is only those questions I can review this and use this opportunity to declare that I am a good friend of @glouppe but don't think this creates a conflict of interest.
Thanks for the heads up.
@betatim - basically we just need you to work through the checklist under Reviewer questions
. If anything isn't clear please shout.
Also, there are some additional notes here (http://joss.theoj.org/about#reviewer_guidelines) but the review checklist should represent these guidelines.
Also, thanks so much for helping out!
from joss-reviews.
UI question: how do I tick off things from the list? I think technically it is impossible to organise for me to be able to edit @whedon's comment. Had a scan around openjournals/whedon
to try and find the raw MD but couldn't find it sad 🐼.
from joss-reviews.
- no information for contributing or seeking help.
- In the PDF the reference needs a arxiv ID/DOI, this is a template issue I assume?
edit: should all be in the first comment now
from joss-reviews.
A few "trivial" comments are included inline. I haven't yet tried to answer the "functionality" questions.
re: statement of need in the PDF. It states "support inference in the likelihood-free setup, including density ratio estimation algorithms, parameterized supervised learning and calibration procedures". This could be improved by stating a few concrete problems, that your average researcher can recognise as problems they have, to which it is the solution. Right now I think you have to already know that carl
can solve your problem to realise that it solves your problem.
The first paragraph of the PDF is a bit longer than what is in the README
so I would copy/sync them once a few specific problems are added to it.
Otherwise everything looked good to me.
from joss-reviews.
Thanks Tim! Changes proposed are diana-hep/carl#53
Note: this back and forth between two github repos is not the most convenient :s 🐹
from joss-reviews.
Thanks Tim
from joss-reviews.
UI question: how do I tick off things from the list? I think technically it is impossible to organise for me to be able to edit @whedon's comment. Had a scan around openjournals/whedon to try and find the raw MD but couldn't find it sad 🐼.
@betatim - this is great point (that I didn't consider until now) - you need to be able to edit the issue too :-) I've added you to the joss-reviewers
team which means you should be able to update the original issue.
Archive: Does the software archive resolve? Comment: see openjournals/whedon#1
This should should be fixed 🔜
Also, thanks for the rapid review ⚡
from joss-reviews.
I've moved everything to the first comment. Most of the missing ☑️ are being dealt with in diana-hep/carl#53. Then there is the missing DOI in the generated PDF, do you take care of that @arfon?
from joss-reviews.
Then there is the missing DOI in the generated PDF, do you take care of that @arfon?
Yep, tracking that in openjournals/joss#56
from joss-reviews.
I made further changes at diana-hep/carl#53 (now merged). Is it possible to regenerate the PDF?
from joss-reviews.
Updated paper PDF: paper.pdf
from joss-reviews.
I don't see what the default bib style is in the wehedon resources:
but it looks like \bibliographystyle{utphys}
might give a nice format for the arxiv link in the reference
http://tex.stackexchange.com/questions/243636/mendeley-and-arxiv-citation-style
from joss-reviews.
Updated paper PDF: paper.pdf (now including the archive DOI and software repository address)
from joss-reviews.
Installing works, automated tests pass, and ran some of the examples.
There are no performance claims (as in runs faster than X) so I don't think that reviewer question applies.
Only outstanding issue is rendering of references in the pdf.
from joss-reviews.
@betatim - awesome thanks.
Only outstanding issue is rendering of references in the pdf.
@cranmer @betatim how do you feel about this rendering? paper.pdf
I've not managed to get the utphys
biblio-style working but have managed to format the reference more generically to get the arXiv URL included:
@article{Cranmer:2015-llr,
author = "Cranmer, Kyle and Pavez, Juan and Louppe, Gilles",
title = "{Approximating Likelihood Ratios with Calibrated
Discriminative Classifiers}",
eprinttype = {arxiv},
version = {2},
eprint = {http://arxiv.org/abs/1506.02169v2},
url = {http://arxiv.org/abs/1506.02169v2},
date = {2016-03-18},
}
from joss-reviews.
LGTM. I use the arXiv ID/DOI as a simple way to find the article in google, if you directly link me there even better (appeals to the efficient German in me)
from joss-reviews.
Sorry I missed this earlier. LGTM too.
from joss-reviews.
Woo hoo!
We can provide a testimonial on the review process if you want.
Congratulations to you and the JOSS team. 🎉
from joss-reviews.
Great, thank you all :)
from joss-reviews.
Whoop! 🏁
Our work here is done, closing the issue.
from joss-reviews.
Actually, where do we click to toggle the badge from under review to published?
from joss-reviews.
Actually, where do we click to toggle the badge from under review to published?
@betatim - I have to do this (for now).
from joss-reviews.
I'm so excited!
from joss-reviews.
It seems like the reference is still broken - there's no DOI or URL or way to know where the reference was published or is available
from joss-reviews.
It seems like the reference is still broken - there's no DOI or URL or way to know where the reference was published or is available
Which reference sorry?
from joss-reviews.
Compare https://github.com/openjournals/joss-papers/blob/master/joss.00011/10.21105.joss.00011.pdf (from the journal page) to the last PDF you posted in this issue. The only reference in the PDF has a link to the arxiv in the version you posted here but not in the journal version
Gotcha. Not sure what happened there. Will investigate.
from joss-reviews.
OK, this is fixed in the online PDF now. The PR to fix the bibtex is here: diana-hep/carl#56
from joss-reviews.
Related Issues (20)
- [PRE REVIEW]: EMPIARreader: A Python package interface to EMPIAR HOT 9
- [PRE REVIEW]: evoke: A Python package for evolutionary signalling games HOT 21
- [PRE REVIEW]: QEsee: An interactive visualiser for quantum error correcting codes HOT 8
- [REVIEW]: PyToughReact – A Python Package for automating reactive transport and biodegradation simulations. HOT 18
- [PRE REVIEW]: Ndpolator: fast, n-dimensional linear interpolation and extrapolation on sparse grids HOT 9
- [PRE REVIEW]: terratools: A Python package to analyse TERRA mantle convection simulations HOT 9
- [PRE REVIEW]: scikit-eo: A Python package for Remote Sensing Data Analysis HOT 16
- [REVIEW]: ncompare: A Python package for comparing netCDF structures HOT 11
- [REVIEW]: BiGGer: A Model Transformation Tool written in Java for Bigraph Rewriting in GrGen.NET HOT 8
- [REVIEW]: ATHENA: A Fortran package for neural networks HOT 10
- [PRE REVIEW]: fMRIStroke: A preprocessing pipeline for fMRI Data from Stroke patients HOT 6
- [REVIEW]: CART: A Tool for Making Paper Relevancy Screening Easier HOT 8
- [REVIEW]: STReNGTHS, a python package to model and simulate reaction-diffusion systems HOT 8
- [PRE REVIEW]: findSVI: an R package to calculate the Social Vulnerability Index at multiple geographical levels HOT 18
- [PRE REVIEW]: libsoni: A Python Toolbox for Sonifying Music Annotations and Feature Representations HOT 12
- [PRE REVIEW]: D3mirt: Descriptive Three-Dimensional Multidimensional Item Response Theory for R HOT 21
- [PRE REVIEW]: quadkeyr: Tools for converting QuadKeys (Microsoft's Bing Maps Tile System) into raster images HOT 22
- [REVIEW]: quadkeyr: Tools for converting QuadKeys (Microsoft's Bing Maps Tile System) into raster images HOT 26
- [REVIEW]: 21cmSense v2: A modular, open-source 21 cm sensitivity calculator HOT 8
- [REVIEW]: PolarToolkit: Python Tools for Convenient, Reproducible, and Open Polar Science HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joss-reviews.