[REVIEW]: Scowl: a Scala DSL for programming with the OWL API about joss-reviews HOT 12 CLOSED

Yes, thanks!

from joss-reviews.

/ cc @openjournals/joss-reviewers - would anyone be willing to review this submission?

If you would like to review this submission then please comment on this thread so that others know you're doing a review (so as not to duplicate effort). Something as simple as :hand: I am reviewing this will suffice.

Reviewer instructions

• Please work through the checklist at the start of this issue.
• If you need any further guidance/clarification take a look at the reviewer guidelines here http://joss.theoj.org/about#reviewer_guidelines
• Please make a publication recommendation at the end of your review

Any questions, please ask for help by commenting on this issue! 🚀

from joss-reviews.

✋ I am reviewing this

from joss-reviews.

Review finished, every point is checked but one:

Community guidelines

There is no mention on how to contribute, report bugs or get support.

Please add a 'How to contribute' section to the README with at least a brief statement encouraging posible contributors to help pointing them to open a new github issue. Add also information on how to report a problem (opening an issue should be OK) and seek support (ideas: mailing list, contact email, github issue with a specific tag).
Even better would be to include a CONTRIBUTING.md file with detailed instructions.

Recommendation:

I recommend publication after some minor revisions: contributing guidelines should be added to the documentation.

from joss-reviews.

Thanks for the review @xuanxu! @balhoff - could you take a look at the reviewer's responses and see what you think?

from joss-reviews.

Thanks @xuanxu! I updated the README and added CONTRIBUTING.md. Please let me know what you think.

I also updated paper.bib, hoping to eliminate duplicate URLs in the reference output.

from joss-reviews.

Thanks @balhoff! It looks good to me.
All points checked, this is publication-ready @arfon.

from joss-reviews.

Thanks for the review @xuanxu!

@balhoff http://dx.doi.org/10.21105/joss.00023 🎉 🚀 💥

from joss-reviews.

Great! @arfon would it be possible to regenerate the PDF at this point? I had made some tweaks to the references file hoping to remove duplicated URLs from the output.

from joss-reviews.

@balhoff - I regenerated it when I generate the DOI: https://github.com/openjournals/joss-papers/blob/master/joss.00023/10.21105.joss.00023.pdf

Does ☝️ look good? If not, we can update it.

from joss-reviews.

@arfon I just updated paper.bib to remove the howpublished field. The website citations were showing the URL twice. Hopefully this will fix it. Can you regenerate? Thanks!

from joss-reviews.

Is this better? https://github.com/openjournals/joss-papers/blob/master/joss.00023/10.21105.joss.00023.pdf

from joss-reviews.