[REVIEW]: tidytext: Text Mining and Analysis Using Tidy Data Principles in R about joss-reviews HOT 10 CLOSED

✋ I am reviewing this

Robert

On Sat, Jul 9, 2016, 11:46 PM Arfon Smith [email protected] wrote:

/ cc @openjournals/joss-reviewers
https://github.com/orgs/openjournals/teams/joss-reviewers - would
anyone be willing to review this submission?

If you would like to review this submission then please comment on this
thread so that others know you're doing a review (so as not to duplicate
effort). Something as simple as ✋ I am reviewing this will suffice.

Reviewer instructions

• Please work through the checklist at the start of this issue.
• If you need any further guidance/clarification take a look at the
  reviewer guidelines here
  http://joss.theoj.org/about#reviewer_guidelines
• Please make a publication recommendation at the end of your review

Any questions, please ask for help by commenting on this issue! 🚀

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#37 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABcI-sXux4l5ob24E5IVtyz1USGAYOc3ks5qUGsCgaJpZM4JIwRk
.

from joss-reviews.

@juliasilge - this is now accepted into JOSS. Your DOI is http://dx.doi.org/10.21105/joss.00037 🎉 🚀 💥

from joss-reviews.

/ cc @openjournals/joss-reviewers - would anyone be willing to review this submission?

If you would like to review this submission then please comment on this thread so that others know you're doing a review (so as not to duplicate effort). Something as simple as :hand: I am reviewing this will suffice.

Reviewer instructions

• Please work through the checklist at the start of this issue.
• If you need any further guidance/clarification take a look at the reviewer guidelines here http://joss.theoj.org/about#reviewer_guidelines
• Please make a publication recommendation at the end of your review

Any questions, please ask for help by commenting on this issue! 🚀

from joss-reviews.

I will mention @dgrtwo here so he can follow along as well.

from joss-reviews.

Regarding LICENSE, the LICENSE is the standard CRAN implementation of the MIT LICENSE, which while not exactly standard for OSS, is the standard for CRAN. Therefore I am checking it off.

from joss-reviews.

Below is my review, which is basically copy pasting the above checklist, with some commentary interspersed. All checked off, I recommend to publish as-is.

@juliasilge and @dgrtwo: one of the vignettes installing from CRAN did not have the correct title, but I see in the github repo it has been corrected, so no issues. That was the only beef I had.

Reviewer questions

Conflict of interest

• As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?

Regarding LICENSE, the LICENSE is the standard CRAN implementation of the MIT LICENSE, which while not exactly standard for OSS, is the standard for CRAN. Therefore I am checking it off.

• Version: Does the release version given match the GitHub release (v0.1.1)?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: Have any performance claims of the software been confirmed?

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.

dependencies are handled by the R package installation

• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).

The README provides well worked examples showing how the software works, on a real dataset

Various functions have examples, and also included are 4 vignettes (R long-form documentation) that also demonstrate various analyses.

• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g. API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

Paper PDF: 10.21105.joss.00037.pdf

• Authors: Does the paper.md file include a list of authors with their affiliations?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• References: Do all archival references that should have a DOI list one (e.g. papers, datasets, software)?

Issues with Submission

The CRAN installed version does not have the correct title for one of the vignettes, but I would think that it will propagate soon.

Recommendation

Publish as-is

from joss-reviews.

Regarding the package's LICENSE, I did try submitting to CRAN with the contents of the whole MIT license in the LICENSE file, as discussed in the author guidelines, but the CRAN administrators did not go for it.

from joss-reviews.

Right, and I figured that was an issue. That is why I just checked it anyway, because you followed the CRAN guidelines, which is where the package is "published" for ease of installation purposes.

from joss-reviews.

Thanks for the rapid review @rmflight!

@juliasilge - the final thing here is to make an archive of the software in Zenodo/figshare/other similar service and update this thread with the archive DOI. I can then move forward with accepting this submission 😁

from joss-reviews.

I turned on Zenodo before our last, most recent release so there is an archive of v0.1.1, the current version and what is on CRAN right now:

Let me know if anything needs to be changed about that, or if I need to make another release for the JOSS submission specifically or anything like that.

from joss-reviews.