Comments (11)
I will get this reviewed by Friday (8/19) - thanks!
from joss-reviews.
Adding a note for reference: rdefra went through JOSS and rOpenSci review in parallel, having been submitted before our joint-review workflow was in place but approved after. The rOpenSci review can be found here: ropensci/software-review#68
from joss-reviews.
/ cc @openjournals/joss-reviewers - would anyone be willing to review this submission?
If you would like to review this submission then please comment on this thread so that others know you're doing a review (so as not to duplicate effort). Something as simple as :hand: I am reviewing this
will suffice.
Reviewer instructions
- Please work through the checklist at the start of this issue.
- If you need any further guidance/clarification take a look at the reviewer guidelines here http://joss.theoj.org/about#reviewer_guidelines
- Please make a publication recommendation at the end of your review
Any questions, please ask for help by commenting on this issue!
from joss-reviews.
Web scraping is a notoriously fragile method.
This software consists of 243 lines of R code. I would like to ask the
author to confirm here that he thinks this software is a valuable
contribution to research. I want to point out that once this work has
been published it will be visible for a long time. Adding an example
of having used this tool in research would be a good idea.
from joss-reviews.
This is part of the openSci R package and provides access to the Air Information Resource UK-AIR of the Department for Environment, Food and Rural Affairs in the United Kingdom (no public API available today).
@cvitolo - Can you please confirm the following are included?
- a plain-text LICENSE file with the contents of an OSI approved software license
- release version number in documentation matching Github
The readme references in usage ukair_catalogue(). However, that method is no longer available. Using catalogue() is available instead. ukair_get_coordinates is also not available. Can the readme and provided examples please be updated to match the current methods?
If any automated tests can be provided apart from the provided examples, please include the same.
from joss-reviews.
rdefra - response to reviewers (step 1)
Many thanks for reviewing my paper/package. Below are my responses to reviewers' comments.
@pjotrp
- I agree web scraping is a fragile method but without pubblic APIs there are not many alternatives. This is however a temporary solution, when APIs will become available I'll update the package to work with those.
- I wrote this software to carry out my own research and I believe there are many other researchers that could benefit from my work, without the need to re-invent the wheel. In my opinion, this is a valuable contribution to research but it could also be useful for practitioners. I am preparing another journal paper for which I carried out some modelling excercises and used this software to get pollution data. I'll add a link to this second paper as soon as it is published.
@pragyansmita
- Regarding the license, I confirm that the license information is included in the DESCRIPTION file where you can read License: GPL-3. This should be sufficient, according to the Writing R Extensions manual which says that 'It is very important that you include license information [...] If a package license restricts a base license [...] the additional terms should be placed in file LICENSE'. Therefore, if I understand this well, I only need a file called LICENSE is I want to restrict the LICENSE specified in the DESCRIPTION file. Am I correct?
- I confirm that the latest version is 0.3.0 (see Github repository).
- As requested by ROPENSCI reviewers, all the names of the functions in rdefra are now in lower case and have a prefix (ukair):
catalogue()
is now calledukair_catalogue()
EastingNorthing()
is now calledukair_get_coordinates()
get1Hdata()
is now calledukair_get_hourly_data()
getSiteID()
is now calledukair_get_site_id()
README and vignette have been updated accordingly.
- A number of tests have been provided using the testthat framework.
from joss-reviews.
a plain-text LICENSE file with the contents of an OSI approved software license
@pragyansmita - CRAN has some pretty restrictive policies around where the license can be present. See this thread for background: #37 (comment)
I believe that @cvitolo has adhered to the CRAN guidelines here which is acceptable to JOSS.
from joss-reviews.
@cvitolo Thank you for the information
@arfon Thank you
Recommend for publication. @arfon : Please let me know if anything else is needed. Thanks!
from joss-reviews.
Recommend for publication. @arfon : Please let me know if anything else is needed. Thanks!
Thanks @pragyansmita.
@cvitolo - at this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.
from joss-reviews.
Many thanks @arfon - I have just made a new release v0.3.2, here is the doi url: http://dx.doi.org/10.5281/zenodo.61033
from joss-reviews.
Thanks for the review @pragyansmita
@cvitolo - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00051
from joss-reviews.
Related Issues (20)
- [PRE REVIEW]: DustPyLib: A Library of DustPy Extensions HOT 14
- [REVIEW]: ViMag: A Visual Vibration Analysis Toolbox HOT 13
- [REVIEW]: baseflow: a MATLAB and GNU Octave package for baseflow recession analysis HOT 22
- [PRE REVIEW]: arulespy: Exploring Association Rules and Frequent Itemsets in Python HOT 15
- [REVIEW]: nctoolkit: A Python package for netCDF analysis and post-processing HOT 13
- [REVIEW]: PyAMG: Algebraic Multigrid Solvers in Python HOT 14
- [REVIEW]: iTensor: An R package for independent component analysis-based matrix/tensor decomposition HOT 7
- [REVIEW]: OpenTera: A Framework for Telehealth Applications HOT 7
- [PRE REVIEW]: SAMM (Segment Any Medical Model): A 3D Slicer Integration to SAM HOT 12
- [REVIEW]: PreliZ: A tool-box for prior elicitation HOT 7
- [REVIEW]: A Python Tool for Predicting and Assessing Unconventional Rare-Earth and Critical Mineral Resources HOT 17
- [PRE REVIEW]: PASCal Python: A Principal Axis Strain Calculator HOT 38
- [PRE REVIEW]: samgeo: A Python package for segmenting geospatial data with the Segment Anything Model (SAM) HOT 9
- [PRE REVIEW]: TRAINING AND PLACEMENT PORTAL. HOT 7
- [REVIEW]: qujax: Simulating quantum circuits with JAX HOT 10
- [REVIEW]: occupationMeasurement: A Comprehensive Toolbox for Interactive Occupation Coding in Surveys HOT 7
- [PRE REVIEW]: OasisMove: A Verified and Validated FEniCS-based Computational Fluid Dynamics Solver for Moving Domains HOT 13
- [PRE REVIEW]: NEMSEER: A Python package for downloading and handling historical National Electricity Market forecast data produced by the Australian Energy Market Operator HOT 9
- [PRE REVIEW]: pvOps: a Python package for empirical analysis of photovoltaic field data HOT 8
- [PRE REVIEW]: Time-frequency component of the Green-X library: minimax grids for efficient RPA and GW calculations HOT 31
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joss-reviews.