Giter VIP home page Giter VIP logo

Comments (40)

kyleniemeyer avatar kyleniemeyer commented on July 20, 2024 1

@editorialbot invite @Kevin-Mattheus-Moerman as editor

from joss-reviews.

frederickgosselin avatar frederickgosselin commented on July 20, 2024 1

Hi Kevin,
Thanks for the invitation. This is a bit besides my area of expertise. Perhaps my colleague Martin Levesque at Polytechnique MontrΓ©al or his former PhD student Elias Ghossein who now work at Maya HTT could be available. This is dead on their specialty.

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024
Software report:

github.com/AlDanial/cloc v 1.88  T=0.20 s (380.8 files/s, 229841.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              8              3             51          22133
JavaScript                      14           2420           2485           9106
HTML                            16            543             48           4103
Python                          10            291            619            879
Jupyter Notebook                 5              0           1795            788
CSS                              5            187             39            759
TeX                              1             22              0            270
Markdown                         5             70              0            216
YAML                             2              7              4             42
reStructuredText                10             35             66             40
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            78           3590           5115          38371
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

Wordcount for paper.md is 889

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mechmat.2022.104307 is OK
- 10.21105/joss.04389 is OK
- 10.1115/1.3153710 is OK
- 10.1007/978-3-030-28983-6 is OK
- 10.1122/1.549945 is OK
- 10.1016/0001-6160(73)90064-3 is OK
- 10.1088/0508-3443/3/3/302 is OK
- 10.1088/978-0-7503-1454-1ch26 is OK
- 10.1016/0167-6636(87)90005-6 is OK
- 10.5445/KSP/1000070061 is OK
- 10.1007/978-3-662-46737-4 is OK
- 10.1002/pc.750050413 is OK
- 10.1007/978-94-009-3489-4 is OK
- 10.1016/S0266-3538(97)00129-2 is OK
- 10.1016/j.mechmat.2023.104555 is OK
- 10.1016/S1359-835X(97)00117-6 is OK
- 10.1016/0010-4361(78)90341-5 is OK
- 10.1016/j.compositesa.2014.08.027 is OK
- 10.5281/zenodo.6461940 is OK
- 10.5281/zenodo.4029448 is OK

MISSING DOIs

- 10.21236/ad0692481 may be a valid DOI for title: Effects of Environmental Factors on Composite Materials

INVALID DOIs

- None

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

πŸ‘‰πŸ“„ Download article proof πŸ“„ View article proof on GitHub πŸ“„ πŸ‘ˆ

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

Potential reviewer seem to be timokoch, shravantata, sthavishtha and mbagheri20, to name a few.

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

@editorialbot commands

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

Hello @Extraweich, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

@editorialbot check references

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mechmat.2022.104307 is OK
- 10.21105/joss.04389 is OK
- 10.1115/1.3153710 is OK
- 10.1007/978-3-030-28983-6 is OK
- 10.1122/1.549945 is OK
- 10.1016/0001-6160(73)90064-3 is OK
- 10.1088/0508-3443/3/3/302 is OK
- 10.21236/ad0692481 is OK
- 10.1088/978-0-7503-1454-1ch26 is OK
- 10.1016/0167-6636(87)90005-6 is OK
- 10.5445/KSP/1000070061 is OK
- 10.1007/978-3-662-46737-4 is OK
- 10.1002/pc.750050413 is OK
- 10.1007/978-94-009-3489-4 is OK
- 10.1016/S0266-3538(97)00129-2 is OK
- 10.1016/j.mechmat.2023.104555 is OK
- 10.1016/S1359-835X(97)00117-6 is OK
- 10.1016/0010-4361(78)90341-5 is OK
- 10.1016/j.compositesa.2014.08.027 is OK
- 10.5281/zenodo.6461940 is OK
- 10.5281/zenodo.4029448 is OK

MISSING DOIs

- None

INVALID DOIs

- None

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

@editorialbot check repository

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024
Software report:

github.com/AlDanial/cloc v 1.88  T=0.22 s (348.8 files/s, 210427.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              8              3             51          22133
JavaScript                      14           2420           2485           9106
HTML                            16            544             48           4087
Python                          10            291            617            879
Jupyter Notebook                 5              0           1795            788
CSS                              5            187             39            759
TeX                              1             22              0            271
Markdown                         5             70              0            216
YAML                             2              7              4             42
reStructuredText                10             35             66             40
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            78           3591           5113          38356
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

Wordcount for paper.md is 889

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

πŸ‘‰πŸ“„ Download article proof πŸ“„ View article proof on GitHub πŸ“„ πŸ‘ˆ

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

I think a better label would be "Track: 3 PE", since it is really more of an engineering / material science / material physics software.

from joss-reviews.

kyleniemeyer avatar kyleniemeyer commented on July 20, 2024

Hi @Extraweich, we made that track move, and @Kevin-Mattheus-Moerman has volunteered to edit your submission. We'll use this issue to also find reviewersβ€”any suggestions you have would be welcome.

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

Invitation to edit this submission sent!

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@editorialbot assign me as editor

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

Assigned! @Kevin-Mattheus-Moerman is now the editor

from joss-reviews.

Extraweich avatar Extraweich commented on July 20, 2024

@editorialbot assign me as editor

Thanks a lot for your volunteering!

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@JulianKarlBauer you are a code contributor for this work but not listed as an author. @Extraweich it may be okay to exclude certain contributors as authors, but I am just raising this here in case this is by mistake or in case the contributor in questions feels co-authorship would be appropriate. Can you confirm the author set of the paper is accurate/complete? Note, if you like, you may also consider acknowledging contributors in the paper's acknowledgement section.

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@nicoguaro, @likask, @lizarett, @nickelnine37, @frederickgosselin, @PolymerGuy, @fmatuschke
would you be interested in reviewing this submission for JOSS? It concerns a "Python package for homogenization procedures in fiber reinforced polymers".

Paper
Software

from joss-reviews.

likask avatar likask commented on July 20, 2024

@Kevin-Mattheus-Moerman Happy to do this.

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@editorialbot add @likask as reviewer

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

@likask added to the reviewers list!

from joss-reviews.

nicoguaro avatar nicoguaro commented on July 20, 2024

@Kevin-Mattheus-Moerman, I can help with this.

from joss-reviews.

lizarett avatar lizarett commented on July 20, 2024

hello, this is a bit aside from my knowledge, but i can look. please, add me @Kevin-Mattheus-Moerman

from joss-reviews.

nickelnine37 avatar nickelnine37 commented on July 20, 2024

Hi @Kevin-Mattheus-Moerman, this looks interesting but it's also a little far outside of my area of expertise, so I will have to decline. Best wishes. Ed

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@editorialbot add @nicoguaro as reviewer

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

@nicoguaro added to the reviewers list!

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@lizarett I'll add you an an $(n+1)^{th}$ reviewer, since you expressed an interest.

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@editorialbot add @lizarett as reviewer

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

@lizarett added to the reviewers list!

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@editorialbot start review

from joss-reviews.

editorialbot avatar editorialbot commented on July 20, 2024

OK, I've started the review over in #5295.

from joss-reviews.

JulianKarlBauer avatar JulianKarlBauer commented on July 20, 2024

@JulianKarlBauer you are a code contributor for this work but not listed as an author. @Extraweich it may be okay to exclude certain contributors as authors, but I am just raising this here in case this is by mistake or in case the contributor in questions feels co-authorship would be appropriate. Can you confirm the author set of the paper is accurate/complete? Note, if you like, you may also consider acknowledging contributors in the paper's acknowledgement section.

Thank you @Kevin-Mattheus-Moerman for raising this question. @Extraweich kindly contacted me beforehand and again after your remark. I only did a little bit of code clean-up and took the opportunity to compare some minor features which homopy shares with mechkit and mechmean. These comparisons actually made their way to the tests, which I am very happy about. However, I did not contribute to the actual new content within homopy nor the paper itself. Therefore, I think that co-authorship is not appropriate. Thank you again for raising the question :)
And thanks @Extraweich for making this great contribution and giving the opportunity for comparisons, this is very valuable.

from joss-reviews.

Kevin-Mattheus-Moerman avatar Kevin-Mattheus-Moerman commented on July 20, 2024

@JulianKarlBauer okay, thanks for getting back to us with this information.

from joss-reviews.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.