[PRE REVIEW]: PyFlowline a mesh independent river network generator for hydrologic models about joss-reviews HOT 25 CLOSED

Hi @changliao1025 and thanks for your submission. Can you provide more information about the other paper submitted that uses this package? Specifically we want to be sure that 1. the other paper review did not entail a software review, since that is what JOSS does, and 2. there is substantial enough scholarly effort to justify two papers — usually this means a high standard for the software package (my initial quick on the repo check looked good!).

from joss-reviews.

@kthyng thanks for the invite! I'm happily the editor.

from joss-reviews.

@observingClouds Hi, I have identified a few candidates: dvalters; kmarkert; arbennett; and crvernon. Thanks.

from joss-reviews.

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

from joss-reviews.

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.5558988 is OK
- 10.5194/hess-26-5473-2022 is OK
- 10.1029/2022MS003089 is OK

MISSING DOIs

- None

INVALID DOIs

- None

from joss-reviews.

Software report:

github.com/AlDanial/cloc v 1.88  T=1.48 s (89.7 files/s, 303952.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            22              2              0         420104
Python                          69           1982           1794           8325
C++                              1            331           1115           6043
C                                1            328           1093           5936
reStructuredText                19            309             65            683
Cython                           2            100             63            262
DOS Batch                        2             37              2            238
make                             2             49              6            209
Markdown                         6             87              0            109
YAML                             5             15             28             77
Jupyter Notebook                 1              0            978             67
TeX                              1              3              0             35
INI                              1              4              0             13
TOML                             1              0              0              6
-------------------------------------------------------------------------------
SUM:                           133           3247           5144         442107
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

from joss-reviews.

Wordcount for paper.md is 743

from joss-reviews.

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

from joss-reviews.

The paper published recently is Topological Relationship-Based Flow Direction Modeling: Mesh-Independent River Networks Representation. The main objective of this paper is to provide scientific evidence and practical applications for this mesh-independent model. It demonstrates that the new method can achieve comparable or even superior results than the conventional methods.

Our JOSS submission highlights the quality and potential applications of this model for the hydrology community. We provide detailed documentation and case study examples to enable the use of our open-source model in various scenarios.

from joss-reviews.

@observingClouds would you be willing to edit this submission? I know it's a bit outside your field.

from joss-reviews.

@editorialbot invite @observingClouds as editor

from joss-reviews.

Invitation to edit this submission sent!

from joss-reviews.

@editorialbot assign me as editor

from joss-reviews.

Assigned! @observingClouds is now the editor

from joss-reviews.

@changliao1025 thank you for your submission. I'll be your editor. Would you mind suggesting some reviewers from the list provided at the beginning of this thread?

from joss-reviews.

@observingClouds So, what should we do next to move forward?

from joss-reviews.

Hi @changliao1025,
Please excuse the delay. I'm still looking for reviewers to start the review process.

from joss-reviews.

@editorialbot add @smchartrand as reviewer

from joss-reviews.

@smchartrand added to the reviewers list!

from joss-reviews.

Thank you @smchartrand to accept the invitation to review.
I'm searching for one more reviewer before starting the review process.

from joss-reviews.

@editorialbot add @andres-patrignani as reviewer

from joss-reviews.

@andres-patrignani added to the reviewers list!

from joss-reviews.

Thank you @andres-patrignani to accept the invitation to review this submission. You communicated that you will be busy in the next weeks, but I'll start the review process now so that @smchartrand can already start.

@changliao1025 please excuse the long waiting time.

from joss-reviews.

@editorialbot start review

from joss-reviews.

OK, I've started the review over in #5446.

from joss-reviews.