Comments (12)
✋ I am reviewing this
from joss-reviews.
I have updated the blogpost to reflect the current version usage.
I have added the appveyor CI (which was surprisingly easy).
Thank you! 🎉
[Just to make sure: both were just something I observed and not related to the review here. Both could have gone as easily to the upstream repo as a issue -- and probably should have... sorry about that]
from joss-reviews.
Thanks for the rapid review @JanSchulz ⚡
@rCarto your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00054 🚀 🎉 💥
from joss-reviews.
/ cc @openjournals/joss-reviewers - would anyone be willing to review this submission?
If you would like to review this submission then please comment on this thread so that others know you're doing a review (so as not to duplicate effort). Something as simple as :hand: I am reviewing this
will suffice.
Reviewer instructions
- Please work through the checklist at the start of this issue.
- If you need any further guidance/clarification take a look at the reviewer guidelines here http://joss.theoj.org/about#reviewer_guidelines
- Please make a publication recommendation at the end of your review
Any questions, please ask for help by commenting on this issue! 🚀
from joss-reviews.
- Downloaded from the repo via devtools ✔️
- License is GPL (from 2007 -> DESCRIPTION says GPL-3) ✔️
- redid the example in the readme in an jupyter notebook on R 3.3 ✔️ The vignette also worked like a charm ✔️ Unfortunatelly the only EN blogpost in http://rgeomatic.hypotheses.org/842 resulted in some errors (deprecation warnings -> the blogpost seems to require 1.3 but I was on 1.4)
- no performance claims were given, but the run times of the examples were reasonable (compared to cartopy/basemaps in python)
- the paper states what the packages tries to solve ✔️
- the (devtools) installation worked flawless on windows so dependencies are automatically installed ✔️
- the examples solve real world needs ✔️
- checked the API docs and they look great ✔️
- The package is auto checked on travis (Linux) ✔️ (as a windows user I would appreciate appveyor tests as well :-) )
- community guidelines are basically "contribute vie PRs, raise issues or ask questions via issues" -> Minimum is answered ✔️
- paper contains a list of authors with affiliations (and one with an ORCID 👍 ) ✔️
- the references only cite packages or books and an R News item, which seems to have no DOI :-( ✔️
So IMO there is only one question:
- Version on github is 1.4.0 but CRAN is still on 1.3.0 -> what's the problem here? https://github.com/Groupe-ElementR/cartography/releases vs https://cran.r-project.org/web/packages/cartography/index.html -> probably only the CRAN delay as the github release is only from 9h ago...
Apart from that this looks good to publish!
from joss-reviews.
👍 thanks for the rapid review @JanSchulz. @rCarto - please let me know what's happening with the version numbers/releases.
from joss-reviews.
Thanks for the review @JanSchulz.
- I have updated the blogpost to reflect the current version usage.
- I have added the appveyor CI (which was surprisingly easy).
@arfon, concerning the version numbers, I was waiting for possible comments or suggestions from JOSS to integrate. Since comments and suggestions do not imply code changes I will upload this release (v1.4.0) to the CRAN today.
from joss-reviews.
no problem
from joss-reviews.
cartography v1.4.0 is on CRAN now.
from joss-reviews.
@rCarto - could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.
from joss-reviews.
Here is the DOI url of the archive: http://dx.doi.org/10.5281/zenodo.60878
from joss-reviews.
Many thanks!
from joss-reviews.
Related Issues (20)
- [PRE REVIEW]: 4DModeller: a spatio-temporal modelling package HOT 20
- [REVIEW]: Dolphin: A Python package for large-scale InSAR PS/DS processing HOT 8
- [PRE REVIEW]: GLORY: a Python Package for Global Reservoir Water Yield and Cost Estimation HOT 11
- [PRE REVIEW]: DIFFICE-jax: Differentiable neural-network solver for data assimilation of ice shelves in JAX HOT 9
- [PRE REVIEW]: HyperCoast: A Python Package for Visualizing and Analyzing Hyperspectral Data in Coastal Environments HOT 15
- [PRE REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains HOT 16
- [PRE REVIEW]: biopixR: Extracting Insights from Biological Images HOT 14
- [PRE REVIEW]: Advances in training for data sonification: The sonoTrainings web platform HOT 10
- [REVIEW]: OpenMD: A parallel molecular dynamics engine for complex systems and interfaces HOT 7
- [PRE REVIEW]: hoboR: An R package to summarize and manipulate weather station data HOT 11
- [PRE REVIEW]: modisfast: An R package for fast and efficient access to MODIS, VIIRS and GPM Earth Observation data HOT 28
- [PRE REVIEW]: LorenzCycleToolkit: A Comprehensive Python Tool for Analyzing Atmospheric Energy Cycles HOT 17
- [REVIEW]: spatPomp: An R package for spatiotemporal partially observed Markov process models HOT 7
- [REVIEW]: commensurability: a Python package for classifying astronomical orbits based on their toroid volume HOT 8
- [PRE REVIEW]: TSE: A triple stellar evolution code HOT 8
- [PRE REVIEW]: CompressedBeliefMDPs.jl: A Julia Package for Solving Large POMDPs with Belief Compression HOT 7
- [REVIEW]: universalmotif: An R package for biological motif analysis HOT 7
- [REVIEW]: MDCraft: A Python assistant for performing and analyzing molecular dynamics simulations of soft matter systems HOT 12
- [PRE REVIEW]: ngsPETSc: A coupling between NETGEN/NGSolve 2 and PETSc HOT 12
- [PRE REVIEW]: ProbNumDiffEq.jl: Probabilistic Numerical Solvers for Ordinary Differential Equations in Julia HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joss-reviews.