Giter VIP home page Giter VIP logo

Comments (9)

editorialbot avatar editorialbot commented on July 4, 2024

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on July 4, 2024 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.21 s (826.1 files/s, 188576.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            55           2343            165          18032
Python                          62           1841           3508           7372
SVG                              1              0              0           2671
JavaScript                      10            124            186            780
CSS                              4            185             35            762
Markdown                         2            128              0            410
reStructuredText                31            197            488            399
JSON                             2              0              0             88
YAML                             3              9             18             53
TeX                              1              0              0             46
DOS Batch                        1              8              1             26
TOML                             1              2              0             21
INI                              1              5              9             16
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           175           4846           4417          30685
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

from joss-reviews.

editorialbot avatar editorialbot commented on July 4, 2024 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cageo.2012.04.008 is OK
- 10.1016/j.cageo.2016.06.014 is OK
- 10.21105/joss.02412 is OK
- 10.1111/j.1745-6584.2008.00462.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

from joss-reviews.

editorialbot avatar editorialbot commented on July 4, 2024

Wordcount for paper.md is 2011

from joss-reviews.

kyleniemeyer avatar kyleniemeyer commented on July 4, 2024

I'm going to note that this is a re-re-submission (first: #4260, second: #5203).

@temmy222, can you please describe how you have addressed the major issues that @matthewfeickert (and others previously) had raised?

from joss-reviews.

editorialbot avatar editorialbot commented on July 4, 2024

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

from joss-reviews.

temmy222 avatar temmy222 commented on July 4, 2024

Hi @kyleniemeyer . I believe all the points have been addressed. There's a documentation page here https://pytoughreact.readthedocs.io/en/latest/. Tests have also been added. The code also only shows pytoughreact code. Please let me know if there are any other points yet to be addressed

from joss-reviews.

matthewfeickert avatar matthewfeickert commented on July 4, 2024

Hi @kyleniemeyer . I believe all the points have been addressed. There's a documentation page here https://pytoughreact.readthedocs.io/en/latest/. Tests have also been added. The code also only shows pytoughreact code. Please let me know if there are any other points yet to be addressed

👋 @temmy222 The expectation is that the state of the repository at a specific tag that a user will see is that is going to be reviewed. The version listed is v1.0.0 but there is no corresponding tag in https://github.com/temmy222/PyTOUGHREACT/tags.

Further, the default branch master has no commits on it since temmy222/PyTOUGHREACT@32d8324 in February, 2023. It seems that in addition to the paper, the

Branch with paper.md (empty if default branch): master_refactor

branch has the additional changes you've implemented, like the start of tests (though the coverage is quite low), but the expectation is that reviewers do not have to checkout a review branch. I think it is also safe to say that the current state of the docs (https://pytoughreact.readthedocs.io/en/latest/index.html) needs quite a bit of improvement as it is currently an incomplete collection of API references.

As I previously noted in #5203 (comment) I would strongly recommend that you carefully read the Review criteria docs and use them as a guide for preparing your submission.

from joss-reviews.

temmy222 avatar temmy222 commented on July 4, 2024

Thanks for your feedback. I will further improve on it and resubmit

from joss-reviews.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.