[REVIEW]: hebbRNN: A Reward-Modulated Hebbian Learning Rule for Recurrent Neural Networks about joss-reviews HOT 18 CLOSED

OK, the reviewer is @cMadan

from joss-reviews.

/ cc @openjournals/joss-reviewers - would anyone be willing to review this submission?

If you would like to review this submission then please comment on this thread so that others know you're doing a review (so as not to duplicate effort). Something as simple as :hand: I am reviewing this will suffice.

Reviewer instructions

• Please work through the checklist at the start of this issue.
• If you need any further guidance/clarification take a look at the reviewer guidelines here http://joss.theoj.org/about#reviewer_guidelines
• Please make a publication recommendation at the end of your review

Any questions, please ask for help by commenting on this issue! 🚀

from joss-reviews.

✋ I am reviewing this

from joss-reviews.

@whedon commands

from joss-reviews.

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

from joss-reviews.

@whedon assign @cMadan as reviewer

from joss-reviews.

@JonathanAMichaels - sorry for the delay in reviewing your submission.

I looked at the documentation, tried the examples, and checked over everything--your submission impressively follows the JOSS guidelines as-submitted!

I have only two minor suggestions that need to be addressed:
(1) paper.bib, references are missing DOIs.
(2) README.md, typo: "dependecies"

Pending these very minor changes, I am happy to recommend the submission be accepted at JOSS.

from joss-reviews.

Thank you for the very positive review!

I have corrected both errors with the exception of one reference that does not have a DOI.

from joss-reviews.

Looks good to me!

@arfon - I am happy to recommend this submission be accepted at JOSS.

from joss-reviews.

@arfon - I am happy to recommend this submission be accepted at JOSS.

@cMadan thanks for turning this around quickly.

@JonathanAMichaels at this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

from joss-reviews.

@arfon Done! Here's the archive:

from joss-reviews.

@whedon commands

from joss-reviews.

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

from joss-reviews.

@whedon set 10.5281/zenodo.154745 as archive

from joss-reviews.

OK. 10.5281/zenodo.154745 is the archive.

from joss-reviews.

@whedon set 10.5281/zenodo.154745 as archive

from joss-reviews.

OK. 10.5281/zenodo.154745 is the archive.

from joss-reviews.

Thanks again for the review @cMadan!

@JonathanAMichaels your paper is now accepted into JOSS. Your paper DOI is http://dx.doi.org/10.21105/joss.00060 🎉 🚀 💥

from joss-reviews.