Comments (36)
vissarion
commented on August 16, 2024
2
@danielskatz I can take it.
from joss-reviews.
danielskatz
commented on August 16, 2024
1
Thanks for your fixes @DanielVandH
from joss-reviews.
Datseris
commented on August 16, 2024
1
Sorry, I don't have any time to spare at the moment I'm fully booked.
from joss-reviews.
PieterjanRobbe
commented on August 16, 2024
1
Sure, I'm available!
from joss-reviews.
fverdugo
commented on August 16, 2024
1
Hi, I cannot review a paper this time. I will happy to help again in the future.
from joss-reviews.
editorialbot
commented on August 16, 2024
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdf
from joss-reviews.
editorialbot
commented on August 16, 2024
Software report:
github.com/AlDanial/cloc v 1.90 T=0.45 s (616.6 files/s, 166696.1 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Julia 187 5186 11288 41961
Markdown 75 2053 0 9646
TOML 6 705 2 3323
TeX 1 25 0 212
YAML 6 9 11 175
JSON 1 0 0 22
-------------------------------------------------------------------------------
SUM: 276 7978 11301 55339
-------------------------------------------------------------------------------
Commit count by author:
530 DanielVandH
49 Daniel VandenHeuvel
3 dependabot[bot]
2 Júlio Hoffimann
1 CompatHelper Julia
1 Simon
1 himcraft
from joss-reviews.
editorialbot
commented on August 16, 2024
Paper file info:
📄 Wordcount for paper.md is 969
✅ The paper includes a Statement of need section
from joss-reviews.
editorialbot
commented on August 16, 2024
License info:
✅ License found: MIT License (Valid open source OSI approved license)
from joss-reviews.
editorialbot
commented on August 16, 2024
from joss-reviews.
editorialbot
commented on August 16, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1016/S0925-7721(98)00035-2 is OK
- 10.5281/zenodo.11178646 is OK
- 10.5281/zenodo.11176971 is OK
MISSING DOIs
- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Voronoi Diagrams and Delaunay Triangulations
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: Delaunay refinement mesh generation of curve-bound...
- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.1016/s0168-874x(96)00054-6 may be a valid DOI for title: Delaunay triangulation and 3D adaptive mesh genera...
- 10.1137/050643568 may be a valid DOI for title: Adaptive finite element methods for elliptic PDEs ...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- 10.1016/s0070-2153(07)81013-1 may be a valid DOI for title: Delaunay-object-dynamics: Cell mechanics with a 3D...
- No DOI given, and none found for title: Centroidal Voronoi tessellations: Applications and...
- 10.1101/2022.09.13.507714 may be a valid DOI for title: Calibration of agent based models for monophasic a...
- 10.1007/bfb0014497 may be a valid DOI for title: Triangle: Engineering a 2D quality mesh generator...
- No DOI given, and none found for title: MATLAB version: R2024a
- 10.1109/wcica.2008.4593771 may be a valid DOI for title: Path planning based on constrained Delaunay triang...
- No DOI given, and none found for title: SciPy 1.0: Fundamental Algorithms for Scientific C...
- No DOI given, and none found for title: CGAL User and Reference Manual
- No DOI given, and none found for title: Gmsh: a three-dimensional finite element mesh gene...
- 10.31224/3017 may be a valid DOI for title: New computational tools and experiments reveal how...
- 10.21105/joss.03349 may be a valid DOI for title: Makie.jl: Flexible high-performance data visualiza...
- No DOI given, and none found for title: A Guide to First Passage Processes
- 10.1088/1751-8121/ac4a1d may be a valid DOI for title: Mean exit time in irregularly-shaped annular and c...
INVALID DOIs
- None
from joss-reviews.
danielskatz
commented on August 16, 2024
👋 @DanielVandH - Thanks for your submission.
Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.
from joss-reviews.
DanielVandH
commented on August 16, 2024
Thanks @danielskatz. I'll check out the compiling issues - it worked when I did it in https://github.com/JuliaGeometry/DelaunayTriangulation.jl/actions/runs/9697066359, did I configure the workflow file incorrectly?
I'll get all the DOIs fixed up. I'll get them manually incase some of them are incorrect as you suggest, thanks.
from joss-reviews.
DanielVandH
commented on August 16, 2024
@DanielVandH if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Of those that I can see in that list, Kevin Moerman and juliohm are probably suitable.
from joss-reviews.
DanielVandH
commented on August 16, 2024
@editorialbot check references
from joss-reviews.
editorialbot
commented on August 16, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1142/8685 is OK
- 10.1016/S0925-7721(98)00035-2 is OK
- 10.14288/1.0067778 is OK
- 10.1137/141000671 is OK
- 10.1016/S0168-874X(96)00054-6 is OK
- 10.1137/050643568 is OK
- 10.1016/S0070-2153(07)81013-1 is OK
- 10.1137/S0036144599352836 is OK
- 10.1007/s00285-024-02045-4 is OK
- 10.1007/BFb0014497 is OK
- 10.1109/WCICA.2008.4593771 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1002/nme.2579 is OK
- 10.21105/joss.03349 is OK
- 10.5281/zenodo.11178646 is OK
- 10.5281/zenodo.11176971 is OK
- 10.1017/CBO9780511606014 is OK
- 10.1088/1751-8121/ac4a1d is OK
MISSING DOIs
- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- No DOI given, and none found for title: MATLAB version: R2024a
- No DOI given, and none found for title: CGAL User and Reference Manual
INVALID DOIs
- https://doi.org/10.1016/j.cej.2023.145776 is INVALID because of 'https://doi.org/' prefix
from joss-reviews.
DanielVandH
commented on August 16, 2024
@editorialbot check references
from joss-reviews.
editorialbot
commented on August 16, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1142/8685 is OK
- 10.1016/S0925-7721(98)00035-2 is OK
- 10.14288/1.0067778 is OK
- 10.1137/141000671 is OK
- 10.1016/S0168-874X(96)00054-6 is OK
- 10.1137/050643568 is OK
- 10.1016/S0070-2153(07)81013-1 is OK
- 10.1137/S0036144599352836 is OK
- 10.1007/s00285-024-02045-4 is OK
- 10.1007/BFb0014497 is OK
- 10.1109/WCICA.2008.4593771 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1002/nme.2579 is OK
- 10.1016/j.cej.2023.145776 is OK
- 10.21105/joss.03349 is OK
- 10.5281/zenodo.11178646 is OK
- 10.5281/zenodo.11176971 is OK
- 10.1017/CBO9780511606014 is OK
- 10.1088/1751-8121/ac4a1d is OK
MISSING DOIs
- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- No DOI given, and none found for title: MATLAB version: R2024a
- No DOI given, and none found for title: CGAL User and Reference Manual
INVALID DOIs
- None
from joss-reviews.
DanielVandH
commented on August 16, 2024
@editorialbot generate pdf
from joss-reviews.
editorialbot
commented on August 16, 2024
👉📄 Download article proof 📄 View article proof on GitHub 📄 👈
from joss-reviews.
editorialbot
commented on August 16, 2024
Five most similar historical JOSS papers:
Gridap: An extensible Finite Element toolbox in Julia
Submitting author: @fverdugo
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC
Similarity score: 0.7475
Makie.jl: Flexible high-performance data visualization for Julia
Submitting author: @jkrumbiegel
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @fverdugo, @gaelforget
Similarity score: 0.7306
GaussianRandomFields.jl: A Julia package to generate and sample from Gaussian random fields
Submitting author: @PieterjanRobbe
Handling editor: @jbytecode (Active)
Reviewers: @ziyiyin97, @shahmoradi
Similarity score: 0.7302
DynamicalBilliards.jl: An easy-to-use, modular and extendable Julia package for Dynamical Billiard systems in two dimensions.
Submitting author: @Datseris
Handling editor: @kyleniemeyer (Active)
Reviewers: @ahwillia
Similarity score: 0.7222
GridapDistributed: a massively parallel finite element toolbox in Julia
Submitting author: @amartinhuertas
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown
Similarity score: 0.7170
from joss-reviews.
DanielVandH
commented on August 16, 2024
- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- No DOI given, and none found for title: MATLAB version: R2024a
- No DOI given, and none found for title: CGAL User and Reference Manual
As far as I can tell, none of these titles have a DOI assigned to them, and https://www.crossref.org/guestquery also seems to show no DOIs for them.
from joss-reviews.
danielskatz
commented on August 16, 2024
Thanks @danielskatz. I'll check out the compiling issues - it worked when I did it in https://github.com/JuliaGeometry/DelaunayTriangulation.jl/actions/runs/9697066359, did I configure the workflow file incorrectly?
I'll get all the DOIs fixed up. I'll get them manually incase some of them are incorrect as you suggest, thanks.
Sometimes there can be difference between the action and what we do. I'm unsure why, but I'm pinging @openjournals/dev in case this is something they can fix.
from joss-reviews.
danielskatz
commented on August 16, 2024
@editorialbot assign @Kevin-Mattheus-Moerman as editor
thanks Kevin!
from joss-reviews.
editorialbot
commented on August 16, 2024
Assigned! @Kevin-Mattheus-Moerman is now the editor
from joss-reviews.
danielskatz
commented on August 16, 2024
@Kevin-Mattheus-Moerman - will you be able to get started on this soon?
from joss-reviews.
danielskatz
commented on August 16, 2024
👋 @vissarion & @hugoledoux - I know you are both at your limits currently, but there is at least an appearance of a COI with @Kevin-Mattheus-Moerman and this submission, so I wonder if either of you would be able to take it, even if you can't start on it immediately?
from joss-reviews.
danielskatz
commented on August 16, 2024
@editorialbot assign @vissarion as editor
Thanks!
from joss-reviews.
editorialbot
commented on August 16, 2024
Assigned! @vissarion is now the editor
from joss-reviews.
vissarion
commented on August 16, 2024
Hi @fverdugo @PieterjanRobbe @Datseris @amartinhuertas would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html
from joss-reviews.
DanielVandH
commented on August 16, 2024
@editorialbot generate pdf
from joss-reviews.
editorialbot
commented on August 16, 2024
👉📄 Download article proof 📄 View article proof on GitHub 📄 👈
from joss-reviews.
editorialbot
commented on August 16, 2024
Five most similar historical JOSS papers:
Makie.jl: Flexible high-performance data visualization for Julia
Submitting author: @jkrumbiegel
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @fverdugo, @gaelforget
Similarity score: 0.7483
Gridap: An extensible Finite Element toolbox in Julia
Submitting author: @fverdugo
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC
Similarity score: 0.7394
Ripserer.jl: flexible and efficient persistent homology computation in Julia
Submitting author: @mtsch
Handling editor: @VivianePons (Retired)
Reviewers: @juliohm, @sauln
Similarity score: 0.7282
DynamicalBilliards.jl: An easy-to-use, modular and extendable Julia package for Dynamical Billiard systems in two dimensions.
Submitting author: @Datseris
Handling editor: @kyleniemeyer (Active)
Reviewers: @ahwillia
Similarity score: 0.7278
AeroAcoustics.jl: A Julia package for aeroacoustics
Submitting author: @1oly
Handling editor: @faroit (Active)
Reviewers: @nantonel, @thejasvibr
Similarity score: 0.7217
from joss-reviews.
DanielVandH
commented on August 16, 2024
Just had to make a quick update to the summary (specifically "making use of AdaptivePredicates.jl and ExactPredicates.jl for computing predicates with robust arithmetic", AdaptivePredicates.jl is the new default rather than only ExactPredicates.jl) after I upgraded DelaunayTriangulation.jl to v1.1.0
from joss-reviews.
vissarion
commented on August 16, 2024
@editorialbot add @PieterjanRobbe as reviewer
from joss-reviews.
editorialbot
commented on August 16, 2024
@PieterjanRobbe added to the reviewers list!
from joss-reviews.
Related Issues (20)
- [PRE REVIEW]: TDAvec: An R Package for Computing Vector Summaries of Persistence Diagrams for Topological Data Analysis HOT 19
- [PRE REVIEW]: Metasyn: Transparent Generation of Synthetic Tabular Data with Privacy Guarantees HOT 25
- [REVIEW]: plasticparcels: A python package for marine plastic dispersal simulations and parameterisation development using parcels HOT 8
- [PRE REVIEW]: seismolab: A Python package for analyzing space-based observations of variable stars HOT 18
- [PRE REVIEW]: GASTLI: A Python package for coupled interior–atmosphere modelling of volatile-rich planets HOT 8
- [PRE REVIEW]: ccviR: an R package and Shiny app to implement the NatureServe Climate Change Vulnerability Index HOT 12
- [REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework HOT 22
- [REVIEW]: Metasyn: Transparent Generation of Synthetic Tabular Data with Privacy Guarantees HOT 10
- [PRE REVIEW]: kifmm-rs: A Kernel Independent Fast Multipole Framework in Rust HOT 28
- [REVIEW]: Fundus Image Toolbox: A Python package for fundus image processing HOT 12
- [REVIEW]: TSE: A triple stellar evolution code HOT 10
- [PRE REVIEW]: bursty_dynamics: A Python package for exploring the temporal properties of longitudinal data HOT 9
- [REVIEW]: EPyT-Flow: A Toolkit for Generating Water Distribution Network Data HOT 10
- [PRE REVIEW]: pycellga: A Python package for improved cellular genetic algorithms HOT 7
- [PRE REVIEW]: constrained_manipulability: A ROS 2 library to Compute and Visualize Constrained Capacities for Robotic Manipulators HOT 7
- [PRE REVIEW]: robot_collision_checking: A Lightweight ROS 2 Interface to FCL (Flexible Collision Library) HOT 7
- [PRE REVIEW]: MathematicaStan, a Mathematica package to interact with Stan HOT 7
- [PRE REVIEW]: Parallel LSH Ontology Matching HOT 10
- [REVIEW]: MocoExtendProblem: Interface Between OpenSim and MATLAB for Rapidly Developing Direct Collocation Goals in Moco HOT 6
- [REVIEW]: CoastalLens: A MATLAB UAV Video Stabilization and Rectification Framework HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joss-reviews.