Comments (13)
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdf
from joss-reviews.
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1109/ICRA.2011.5980567 is OK
- 10.48550/arXiv.1801.09847 is OK
- 10.1109/LRA.2022.3152830 is OK
- 10.1109/ICRA48506.2021.9560835 is OK
- 10.1007/BF01427149 is OK
- 10.15607/rss.2009.v.021 is OK
MISSING DOIs
- None
INVALID DOIs
- None
from joss-reviews.
Software report:
github.com/AlDanial/cloc v 1.90 T=0.05 s (2478.2 files/s, 236252.9 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
C++ 40 798 276 3548
C/C++ Header 45 781 734 2872
Markdown 8 235 0 668
Python 9 248 79 643
YAML 10 64 13 449
CMake 3 46 43 288
TeX 1 5 0 56
Bourne Shell 4 14 0 55
Dockerfile 2 22 0 42
TOML 1 9 0 40
make 1 5 0 23
XML 1 4 3 15
reStructuredText 2 8 12 9
-------------------------------------------------------------------------------
SUM: 127 2239 1160 8708
-------------------------------------------------------------------------------
Commit count by author:
66 k.koide
46 koide3
4 Martin Valgur
2 Atticus Zhou
2 Daisuke Nishimatsu
2 Nikhil Khedekar
from joss-reviews.
Paper file info:
📄 Wordcount for paper.md
is 663
✅ The paper includes a Statement of need
section
from joss-reviews.
License info:
✅ License found: MIT License
(Valid open source OSI approved license)
from joss-reviews.
👉📄 Download article proof 📄 View article proof on GitHub 📄 👈
from joss-reviews.
Review checklist for @versatran01
Conflict of interest
- I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.
Code of Conduct
- I confirm that I read and will adhere to the JOSS code of conduct.
General checks
- Repository: Is the source code for this software available at the https://github.com/koide3/small_gicp?
- License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
- Contribution and authorship: Has the submitting author (@koide3) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
- Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
- Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
- Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
- Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.
Functionality
- Installation: Does installation proceed as outlined in the documentation?
- Functionality: Have the functional claims of the software been confirmed?
- Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)
Documentation
- A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
- Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
- Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
- Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
- Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
- Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support
Software paper
- Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
- A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
- State of the field: Do the authors describe how this software compares to other commonly-used packages?
- Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
- References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
from joss-reviews.
@versatran01 @abougouffa
Thank you so much for reviewing small_gicp!
I'm so glad that my package is going to be reviewed by professionals in the community.
I'm looking forward to hearing any feedback from you.
from joss-reviews.
Review checklist for @abougouffa
Conflict of interest
- I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.
Code of Conduct
- I confirm that I read and will adhere to the JOSS code of conduct.
General checks
- Repository: Is the source code for this software available at the https://github.com/koide3/small_gicp?
- License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
- Contribution and authorship: Has the submitting author (@koide3) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
- Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
- Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
- Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
- Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.
Functionality
- Installation: Does installation proceed as outlined in the documentation?
- Functionality: Have the functional claims of the software been confirmed?
- Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)
Documentation
- A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
- Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
- Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
- Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
- Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
- Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support
Software paper
- Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
- A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
- State of the field: Do the authors describe how this software compares to other commonly-used packages?
- Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
- References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
from joss-reviews.
@editorialbot generate pdf
from joss-reviews.
👉📄 Download article proof 📄 View article proof on GitHub 📄 👈
from joss-reviews.
Hi @versatran01, @abougouffa how is your review going?
from joss-reviews.
Hi @diehlpk
I've read the paper and taken a look at the code but didn't have the time for now to check the code in deep and try it locally. I will try to finish the review next week!
Thanks for your patience!
from joss-reviews.
Related Issues (20)
- [REVIEW]: spatPomp: An R package for spatiotemporal partially observed Markov process models HOT 7
- [REVIEW]: commensurability: a Python package for classifying astronomical orbits based on their toroid volume HOT 8
- [PRE REVIEW]: TSE: A triple stellar evolution code HOT 9
- [PRE REVIEW]: CompressedBeliefMDPs.jl: A Julia Package for Solving Large POMDPs with Belief Compression HOT 13
- [REVIEW]: universalmotif: An R package for biological motif analysis HOT 8
- [REVIEW]: MDCraft: A Python assistant for performing and analyzing molecular dynamics simulations of soft matter systems HOT 13
- [PRE REVIEW]: ngsPETSc: A coupling between NETGEN/NGSolve and PETSc HOT 23
- [PRE REVIEW]: ProbNumDiffEq.jl: Probabilistic Numerical Solvers for Ordinary Differential Equations in Julia HOT 29
- [PRE REVIEW]: Fundus Image Toolbox: A Python package for fundus image processing HOT 8
- [REVIEW]: Adamantine 1.0: A Thermomechanical Simulator for Additive Manufacturing HOT 6
- [REVIEW]: DisCoTec: Distributed higher-dimensional HPC simulations with the sparse grid combination technique HOT 8
- [REVIEW]: PyGMI - a python package for geoscience modelling and interpretation HOT 8
- [REVIEW]: pref_voting: The Preferential Voting Tools package for Python HOT 9
- [REVIEW]: pide: Petrophysical Interpretation tools for geoDynamic Exploration. HOT 7
- [REVIEW]: HoverFast: an accurate, high-throughput, clinically deployable nuclear segmentation tool for brightfield digital pathology images HOT 9
- [REVIEW]: dust_extinction: Interstellar Dust Extinction Models HOT 7
- [REVIEW]: densify: An R package to prune sparse data frames of typological linguistic data HOT 8
- [REVIEW]: HyperCoast: A Python Package for Visualizing and Analyzing Hyperspectral Data in Coastal Environments HOT 12
- [REVIEW]: BlueCelluLab: Biologically Detailed Neural Network Experimentation API HOT 8
- [REVIEW]: FaaSr: R Package for Function-as-a-Service Cloud Computing HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joss-reviews.