Giter VIP home page Giter VIP logo

Comments (43)

Jonathan-E-Gordon avatar Jonathan-E-Gordon commented on July 24, 2024 1

@danielskatz The software was published on CRAN and PyPI in 2021. Due to lab policy, we developed the software in a private Bitbucket repository, which has accumulated over 400 commits since 2021. In January 2024, we initiated a redesign of the software, resulting in 110 commits from 9 authors, representing approximately 7 person-months of work. We can send the whole commit history if that is helpful. This software will also be cited in a Scientific Data paper currently under review, titled β€œMaterials Data Science Ontology (MDS-Onto): Unifying Domain Knowledge in Materials and Applied Data Science” and we believe this software will be very valuable for those generating ontologies, addressing a need in various academic domains.

from joss-reviews.

atrisovic avatar atrisovic commented on July 24, 2024 1

Hi @danielskatz I am about to complete one of my reviews, so I can review this one. Thank you!

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

⚠️ An error happened when generating the pdf.

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot set as branch

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot set main as branch

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Done! branch is now main

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot check repository

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot check references

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (722.0 files/s, 236739.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            338              5           1755
SVG                              2              0            299           1483
R                                4            169            298            797
Python                           8            205            282            636
Markdown                         4            139              0            367
CSV                             10              0              0            145
TeX                              1              8              0             93
TOML                             1              5              0             76
Rmd                              3            487           3528             33
-------------------------------------------------------------------------------
SUM:                            34           1351           4412           5385
-------------------------------------------------------------------------------

Commit count by author:

     8	Jonathan Gordon
     1	Jonathan-E-Gordon

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Paper file info:

πŸ“„ Wordcount for paper.md is 2575

βœ… The paper includes a Statement of need section

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.18 is OK
- 10.1145/2757001.2757003 is OK

MISSING DOIs

- 10.1007/978-3-319-17966-7_21 may be a valid DOI for title: WebVOWL: Web-based Visualization of Ontologies
- No DOI given, and none found for title: Graphviz Python Package
- No DOI given, and none found for title: RDFLib: Python Library for working with RDF
- 10.32614/cran.package.diagrammer may be a valid DOI for title: DiagrammeR: Graph/Network Visualization
- 10.32614/cran.package.rdflib may be a valid DOI for title: rdflib: Tools to Manipulate and Query Semantic Dat...
- No DOI given, and none found for title: PyPI: The Python Package Index
- No DOI given, and none found for title: CRAN: The Comprehensive R Archive Network

INVALID DOIs

- None

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

License info:

βœ… License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

⚠️ An error happened when generating the pdf. Author (Roger H. French) is missing affiliation.

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

πŸ‘‹ @Alexhb02 - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

from joss-reviews.

Jonathan-E-Gordon avatar Jonathan-E-Gordon commented on July 24, 2024

@editorialbot check references

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.18 is OK
- 10.32614/CRAN.package.DiagrammeR is OK
- 10.1145/2757001.2757003 is OK
- 10.32614/CRAN.package.rdflib is OK

MISSING DOIs

- 10.1007/978-3-319-17966-7_21 may be a valid DOI for title: WebVOWL: Web-based Visualization of Ontologies
- No DOI given, and none found for title: Graphviz Python Package
- No DOI given, and none found for title: RDFLib: Python Library for working with RDF
- No DOI given, and none found for title: PyPI: The Python Package Index
- No DOI given, and none found for title: CRAN: The Comprehensive R Archive Network

INVALID DOIs

- None

from joss-reviews.

Jonathan-E-Gordon avatar Jonathan-E-Gordon commented on July 24, 2024

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

πŸ‘‰πŸ“„ Download article proof πŸ“„ View article proof on GitHub πŸ“„ πŸ‘ˆ

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Five most similar historical JOSS papers:

Building, Importing, and Exporting GEXF Graph Files with rgexf
Submitting author: @gvegayon
Handling editor: @fabian-s (Active)
Reviewers: @jonjoncardoso, @corneliusfritz
Similarity score: 0.6791

microViz: an R package for microbiome data visualization and statistics
Submitting author: @david-barnett
Handling editor: @lpantano (Active)
Reviewers: @marypiper, @yoonjeongcha
Similarity score: 0.6780

A reusable tree-based web-visualization to browse EDAM ontology, and contribute to it.
Submitting author: @bryan-brancotte
Handling editor: @pjotrp (Retired)
Reviewers: @alexgarciac
Similarity score: 0.6735

glottospace: R package for language mapping and geospatial analysis of linguistic and cultural data
Submitting author: @SietzeN
Handling editor: @ajstewartlang (Active)
Reviewers: @fauxneticien, @skalyan91
Similarity score: 0.6715

rTASSEL: An R interface to TASSEL for analyzing genomic diversity
Submitting author: @btmonier
Handling editor: @fboehm (Active)
Reviewers: @tkchafin, @tomsing1
Similarity score: 0.6715

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@Alexhb02 & @Jonathan-E-Gordon - JOSS papers are expected to be 250-1000 words in length. This paper is currently over 2500, as shown by the @editorialbot check repository command. If JOSS accepts this for review, you will have to reduce it. Additionally, the remaining suggested DOI appears correct, so at some point, you will need to add it to the entry in the .bib file.

But before we get to that point, I'm going to ask the editors to discuss if it meets the substantial scholarly effort criterion for review by JOSS, due to the relatively small number of lines of code. You should hear back in couple of weeks or so.

As part of this review, editors will look at the repo's commit history. It appears very brief, making me suspect that development happened before the repository was created. Can you say anything about the work that isn't visible here? How many contributors have their been? How much work was involved (in person-months perhaps), and over what period?

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot query scope

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Submission flagged for editorial review.

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@Jonathan-E-Gordon & @Alexhb02 - this has passed the scope review, and I'll now look for an editor

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

πŸ‘‹ @atrisovic - I know you have a bunch of JOSS papers now, but I thought I would see if you are interested in taking on this one, as it seem aligned with your interests. If not, I will probably take it myself, in which case I would appreciate any reviewer suggestions you might have.

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@editorialbot invite @atrisovic as editor

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Invitation to edit this submission sent!

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@Alexhb02 & @Jonathan-E-Gordon - if you have any suggestions for potential reviewers (ideally ~5) then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

@Alexhb02 & @Jonathan-E-Gordon - as previously mentioned, JOSS papers are expected to be 250-1000 words in length. This paper is currently over 2500, as shown by the @editorialbot check repository command. You have to reduce it. Additionally, the remaining suggested DOI (10.1007/978-3-319-17966-7_21 may be a valid DOI for title: WebVOWL: Web-based Visualization of Ontologies) appears correct, so you need to add it to the entry in the .bib file.

from joss-reviews.

Jonathan-E-Gordon avatar Jonathan-E-Gordon commented on July 24, 2024

@danielskatz Would a paper length of about 1200 words be acceptable or does the paper need to be under 1000 words?

from joss-reviews.

danielskatz avatar danielskatz commented on July 24, 2024

1200 is probably fine.

from joss-reviews.

Jonathan-E-Gordon avatar Jonathan-E-Gordon commented on July 24, 2024

@editorialbot check repository

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (728.7 files/s, 233600.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            338              5           1619
SVG                              2              0            299           1483
R                                4            169            298            797
Python                           8            205            282            636
Markdown                         4            113              0            278
CSV                             10              0              0            145
TeX                              1              8              0             96
TOML                             1              5              0             76
Rmd                              3            487           3528             33
-------------------------------------------------------------------------------
SUM:                            34           1325           4412           5163
-------------------------------------------------------------------------------

Commit count by author:

    10	Jonathan Gordon
     1	Jonathan-E-Gordon

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Paper file info:

πŸ“„ Wordcount for paper.md is 1502

βœ… The paper includes a Statement of need section

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

License info:

βœ… License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

from joss-reviews.

Jonathan-E-Gordon avatar Jonathan-E-Gordon commented on July 24, 2024

@editorialbot check repository

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (726.0 files/s, 232325.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            338              5           1607
SVG                              2              0            299           1483
R                                4            169            298            797
Python                           8            205            282            636
Markdown                         4            112              0            271
CSV                             10              0              0            145
TeX                              1              8              0             96
TOML                             1              5              0             76
Rmd                              3            487           3528             33
-------------------------------------------------------------------------------
SUM:                            34           1324           4412           5144
-------------------------------------------------------------------------------

Commit count by author:

    11	Jonathan Gordon
     1	Jonathan-E-Gordon

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Paper file info:

πŸ“„ Wordcount for paper.md is 1391

βœ… The paper includes a Statement of need section

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

License info:

βœ… License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

from joss-reviews.

atrisovic avatar atrisovic commented on July 24, 2024

@editorialbot add me as editor

from joss-reviews.

editorialbot avatar editorialbot commented on July 24, 2024

Assigned! @atrisovic is now the editor

from joss-reviews.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.