Comments (13)
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdf
from joss-reviews.
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1016/j.jchromb.2019.04.009 is OK
- 10.1021/acs.analchem.1c02220 is OK
- 10.1021/acs.analchem.9b02983 is OK
- 10.32614/RJ-2022-050 is OK
- 10.1186/s12859-023-05533-4 is OK
- 10.1021/ac800692c is OK
- 10.3390/metabo12020137 is OK
- 10.1201/9780429447273 is OK
- 10.1021/ac051437y is OK
MISSING DOIs
- No DOI given, and none found for title: Shiny: Web Application Framework for R
- No DOI given, and none found for title: Squallms: Speedy Quality Assurance via Lasso Label...
INVALID DOIs
- None
from joss-reviews.
Software report:
github.com/AlDanial/cloc v 1.90 T=0.01 s (1108.6 files/s, 166910.2 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
R 9 105 489 835
YAML 2 49 78 237
TeX 1 10 0 147
Rmd 1 80 113 135
Markdown 3 41 0 90
-------------------------------------------------------------------------------
SUM: 16 285 680 1444
-------------------------------------------------------------------------------
Commit count by author:
131 wkumler
2 William Kumler
1 William
from joss-reviews.
Paper file info:
📄 Wordcount for paper.md
is 1013
✅ The paper includes a Statement of need
section
from joss-reviews.
License info:
🟡 License found: Other
(Check here for OSI approval)
from joss-reviews.
👉📄 Download article proof 📄 View article proof on GitHub 📄 👈
from joss-reviews.
Five most similar historical JOSS papers:
proteoDA: a package for quantitative proteomics
Submitting author: @ByrumLab
Handling editor: @jmschrei (Active)
Reviewers: @shahmoradi, @MohmedSoudy
Similarity score: 0.7837
RIAssigner: A package for gas chromatographic retention index calculation
Submitting author: @hechth
Handling editor: @dhhagan (Retired)
Reviewers: @yguitton, @davidegraff
Similarity score: 0.7255
matchms - processing and similarity evaluation of mass spectrometry data.
Submitting author: @florian-huber
Handling editor: @arfon (Active)
Reviewers: @bittremieux, @kaibioinfo
Similarity score: 0.7231
Viime: Visualization and Integration of Metabolomics Experiments
Submitting author: @waxlamp
Handling editor: @lpantano (Active)
Reviewers: @joannawolthuis, @rowlandm, @jkanche
Similarity score: 0.7029
patRoon 2.0: Improved non-target analysis workflows including automated transformation product screening
Submitting author: @rickhelmus
Handling editor: @KristinaRiemer (Retired)
Reviewers: @wesleyburr, @hechth
Similarity score: 0.7026
from joss-reviews.
Listing a few potential reviewers from the list and some thoughts about their relevant expertise:
- hechth: Previous experience reviewing metabolomics R packages in JOSS (patRoon)
- adafefe: Chromatography and metabolomics experience plus R
- joewandy: Metabolomics and R experience
- luciorq: Broader expertise with Shiny apps and R packages in bioinformatics
- salix-d: Broader expertise with Shiny apps and R packages in bioinformatics
from joss-reviews.
@wkumler thanks for this submission. As AEiC I'm here to help with initial steps. Note that last week I assigned the query-scope
label. This triggers a scope review by the editorial board. I've done this because of the relatively small size of the project. The scope review will determine if this work conforms to our substantial scholarly effort criteria, and will take about 2 weeks to complete.
from joss-reviews.
@wkumler the editorial board has concluded the scope review for this submission. Unfortunately it is not deemed in scope as it stands. Besides the fact that the code base is rather small and the functionality relatively narrow, there were also concerns raised in terms of "maturity". It was recommended that the authors first push for acceptance in Bioconductor. This will likely require various improvements, such as a reduction of the number of dependencies, and also reduction in the use of global variables. We'd welcome a potential re-submission at such a later point, especially when accompanied by a potential expansion of the functionality.
We will now proceed to reject this submission. Note however, this rejection does not mean the work is not useful or not well put together, in simply means that for the above reasons it is not in scope for JOSS as it stands.
from joss-reviews.
@editorialbot reject
from joss-reviews.
Paper rejected.
from joss-reviews.
@Kevin-Mattheus-Moerman Thank you for the feedback, and thank you as well to the editorial board for considering the submission! I am interested in resubmitting at a future point and so could use some additional comments about what else JOSS is looking for in terms of maturity.
squallms
is actually already on Bioconductor (https://bioconductor.org/packages/devel/bioc/html/squallms.html), admittedly only in the devel branch because I missed the code freeze cutoff for 3.19- Reducing the number of dependencies is an admirable goal and one that I did take seriously when writing the package, so I'm interested in additional advice about how many is too many.
squallms
has ~15 direct dependencies, many of which are likely to be already installed on user's systems (e.g. the tidyverse,shiny
,plotly
,graphics
, etc.). This doesn't feel like a crazy amount, and removing any of these would reduce the functionality of the package as a whole or require code duplication. Is it possible that JOSS is concerned about the number of recursive dependencies?xcms
, for example, has over one hundred packages that it requires but I'm not sure what to do about that if I'd still like to be part of the Bioconductor ecosystem. - I'm not sure at all what a reduction in global variables would look like - I don't currently assign anything to the global environment (as is required by Bioconductor) and the
globalVariables
function is used to avoid warnings thrown during package build with non-standard evaluation (e.g. that required bydata.table
anddplyr
).
My current plan with this project is to wait to resubmit to JOSS until Bioconductor 3.20 releases (in October) with squallms
included, during which I'll work on resolving some of the feature-requests I've got on the Github page. My colleagues and I are already using the package (and have seen interest from other institutions despite the relatively narrow scope) and the goal behind submitting it to JOSS was to avoid having to document the functions encapsulated here in the Methods sections, so perhaps I'll identify additional areas for improvement as we continue to use it. I can also expand the documentation and vignette selection to better emphasize how squallms
interfaces with existing MS software such as Skyline, MSDIAL, and MzMine. Would it be better suited for JOSS if that's done?
from joss-reviews.
Related Issues (20)
- [PRE REVIEW]: GridapSolvers.jl: Scalable multiphysics finite element solvers in Julia HOT 32
- [REVIEW]: ASTE: An artificial solver testing environment for partitioned coupling with preCICE HOT 6
- [PRE REVIEW]: dfitspy: a dfits and fitsort implementation in Python HOT 15
- [REVIEW]: dfitspy: a dfits and fitsort implementation in Python HOT 25
- [PRE REVIEW]: wrenfold: Symbolic code generation for robotics HOT 18
- [PRE REVIEW]: StreamGen: a Python framework for generating streams of labeled data HOT 11
- [PRE REVIEW]: ProSportsDraftData HOT 8
- [PRE REVIEW]: Caliscope: GUI Based Multicamera Calibration and Motion Tracking HOT 14
- [REVIEW]: Bodge: Python package for efficient tight-binding modeling of superconducting nanostructures HOT 7
- [PRE REVIEW]: harmonize-wq: Standardize, clean and wrangle Water Quality Portal data into more analytic-ready formats HOT 10
- [PRE REVIEW]: DVMDOSTEM: a terrestrial ecosystem model designed to represent arctic, boreal and permafrost ecosystem dynamics HOT 9
- [PRE REVIEW]: Pythagora: A Python Package for Modeling the Impact of Social Networks on Market Outcomes HOT 10
- [PRE REVIEW]: PySLSQP: A transparent Python package for the SLSQP optimization algorithm modernized with utilities for visualization and post-processing HOT 32
- [REVIEW]: LorenzCycleToolkit: A Comprehensive Python Tool for Analyzing Atmospheric Energy Cycles HOT 10
- [PRE REVIEW]: `h3ppy`: An open-source Python package for modelling and fitting H$_3^+$ spectra HOT 9
- [PRE REVIEW]: PeakPerformance - A tool for Bayesian inference-based fitting of LC-MS/MS peaks HOT 6
- [PRE REVIEW]: lpcde: Estimation and Inference for Local Polynomial Conditional Density Estimators HOT 7
- [PRE REVIEW]: corrp: An R package for multiple correlation-like analysis and clustering in mixed data HOT 7
- [PRE REVIEW]: ollamar: An R Package for running large language models HOT 11
- [PRE REVIEW]: Teaspoon: A Python Package for Topological Signal Processing HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joss-reviews.