Comments (4)
Hi @infabo - thanks for pointing this out. Seems it was missed while importing the 1.9.1.1 sources. More recent version imports use the process outlined here: #112
which would explain the orphan files still sticking around until now. We'll take this as a bug and remove them asap.
In general merges require at least 2 maintainers' approval. Please let me know if you find anything else like this and we can fix it - but you're right, it's a public Magento mirror that only has a few people behind it (rather than an entire org) so there may be things like this. The beauty is we can hopefully fix them quickly once pointed out since this repo more-or-less belongs to the community.
from magento-lts.
Github PR reviews are great. I don't know if that already applied for the merge back then.
from magento-lts.
The new reviews feature is definitely a huge improvement although I think if we had a few more members it would be good to require three reviewers instead of one.
In this particular case I don't see a few spare xml files as being a serious problem and in general I think we are seeing good bug fixes that make LTS worth using over official CE. Perhaps we should add a "Use at your own risk!" statement to the README? :)
from magento-lts.
@colinmollenhour I think we can probably move ahead with increasing the min #approvals to at least 3. The 2 person approval came from when me, @LeeSaferite, and @Flyingmana were the only active maintainers. Recently it looks like we have many more than that (yay!) so let's go ahead and bump it.
from magento-lts.
Related Issues (20)
- Magento Admin: Input fields text and select drop-downs are different widths in "Attribute Information" page HOT 9
- Online refund (credit) always 0.00 and order complete instead of closed HOT 2
- PHP 8.1 TypeError: imagecopymerge(): Argument #9 ($pct) must be of type int in GD when custom watermark image is applied HOT 1
- The TinyMCE bullet menu stays on top HOT 2
- Can't upgrade from v20.2.0 to v20.3.0 HOT 1
- Unable to save customer in admin console with DOB set to empty HOT 11
- Where is the code that dispatch the event "before_login_post_redirect"? HOT 5
- TODO - Some changes in DDEV HOT 1
- Deprecated functionality: Automatic conversion of false to array is deprecated HOT 1
- Deprecated functionality: nl2br(): Passing null to parameter #1 HOT 5
- Deprecated functionality: trim(): Passing null to parameter #1 ($string) of type string is deprecated HOT 5
- Deprecated functionality: strlen(): Passing null to parameter #1 ($string) of type string is deprecated HOT 2
- Fatal error: Uncaught Error: Call to a member function addData() on null HOT 2
- Deprecated functionality: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
- Deprecated functionality: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
- Fatal error: Uncaught Error: Call to a member function setOnclick() on false HOT 2
- Deprecated functionality: nl2br(): Passing null to parameter #1 ($string) of type string is deprecated
- Deprecated functionality: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
- incorrect currency value HOT 4
- Use redis for session HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento-lts.