Poor Image Quality for Some WebP Images on Product Page about magento-lts HOT 15 CLOSED

@sreichel I just makes me sad that you choose to only participate only when you can uselessly criticize what other people are trying, within their limits, to bring to this wonderful project. Do you want to break the game you don't want to play anymore? I wonder what happened to the person I was working together just a few months ago. Have a good week.

from magento-lts.

please give a test to #3403, it solves for me

from magento-lts.

mmm probably the GD2 based resizing is screwing the images?

from magento-lts.

+1 for untested new features.

from magento-lts.

@hirale interesting, on my machine I can't see the images you provided (in the zipfile) correctly, they look very odd:

I don't know if that's possible but, could they have some specific colorspace or color profile or something I that?

I mean, not even my finder renders them correctly:

from magento-lts.

if I download the test image from google I can render it correctly, while the one in the zip looks bad:

from magento-lts.

ok now I think I understand the problem, this image is "correct" to use as a source image:
4.webp.zip

then I upload it:

at a first glance it looks ok on the frontend:

but then, click the thumbnail:

so, the resizing routines for sure break the image somehow.

from magento-lts.

It could be an issue with images resized by OpenMage. I added one of the images in the product description and as expected it is displayed correctly, see the result below

If I open one of the thumbnails in a new browser window, here is what is displayed in Chrome, and nothing is displayed in Firefox

I will check what happens with a TIFF image saved from Photoshop in WebP format and one saved through an online converter.

from magento-lts.

I used a TIFF image and saved it in Photoshop (latest version) in 3 formats: JPEG, PNG and WebP. By resizing the WebP format, the thumbnail (the one on the right) has a big loss of quality.

If in the Backend the thumbnail is opened in a new window, which is actually the unsized image, this is what is displayed. The highlight, if I drag the image saved on the Desktop into the browser, it is displayed correctly

from magento-lts.

@sreichel - In PR #3384 the feature to use images in WebP format was added to OpenMage. That PR solved 90% of the change and it was not mandatory to make a revert. A problem was identified yesterday and today it was confirmed, at this moment there is a solution that needs to be tested. If it is fine, then the problem is completely solved, We can state there is a new feature added. In addition, by merging that PR we did not affect the users, there is no release to contain it.

Only two people from those with "green approvals" participated in that PR. I would call them the last of the Mohicans who attach daily importance to OpenMage. For my part, I did a test, but I admit that I missed checking the quality of thumbnails and product images when they are used. I don't mind the reproaches in any way, but I would like not to see them, especially coming from people who abandoned the contribution because of personal vendetta.

from magento-lts.

@sreichel I just makes me sad that you choose to only participate only when you can uselessly criticize what other people are trying, within their limits, to bring to this wonderful project. Do you want to break the game you don't want to play anymore? I wonder what happened to the person I was working together just a few months ago. Have a good week.

As said, ive no time to work on OM (nor Magerun), but i was able to reproduce this issue with my first try. My conclusion was, it was not properbly tested and got merged.

After spending tons of time to improve code quality it feels wrong to me to merge everything ASAP just to lower the number of issues or PRs.

You are one of the most active user here, but not found time to share your oppion about #2748? (Same for some other of my PRs.) Using type hints would be great improvement to avoid additional checks and make code clear. Since latest release a lot of new code has been added, w/o carring about this. Changing this later may cause more trouble, so i asked for re-checking newly added methods.

btw ... it seems you ignore all my concerns ... e.g. showing deprecation errors with enabled debug-mode broke a few projects and is something i had to revert.

from magento-lts.

What part of "we do what we can" you don't get?
You've behaved very poorly to me personally, yet I've fixed quite some of your PRs that you purposely left unmaintained. The ones I thought were helpful.
I'm not commenting anything I don't believe in, you're not my boss hence you don't get to decide what I have to do on not.

I still think you comment only when you create problems and to ruin the environment for everybody.
I gave you my full trust in the past and you behaved and behave like it's worth zero, I won't make the same mistake again.

If github had a "block user", like whatsapp, I wouldn't be ruining my evenings every time you decide to write one of your messages.

from magento-lts.

Got it, You're the boss. I will not criticize anything more ...

from magento-lts.

wow

from magento-lts.

Why "wow"? I frequently take a look at the PRs, but due to the lack of time i cant test it, so i can only mention things that feel wrong to me.

from magento-lts.