Revert PR - comments format about magento-lts HOT 10 CLOSED

ah ok so this is the documentation (I searched for that before creating the PR and couldn't find):

In short, it duplicates the doc in the template for all the "vars".

I'd agree to revert if the doc had types but it seems to me that it only has descriptions (https://github.com/OpenMage/magento-lts/pull/3552/files) so I don't see the point of having a template just for a generic description of multiple constants, which don't even explain what the constant does :-\

eg:

it seems not very useful to me to have a duplicate "names" description for those constants, actually it seems worse than just not having the description at all.

But if people think it's important let's revert it.

from magento-lts.

I don't think there's any value in reverting so I'll not participate, but I'll not oppose, obviously.

edit: actually I think the source is far less readable and it would be so much better to have single comments for every const/variable, but with proper description/typing, otherwise what's the point.

from magento-lts.

Does OpenMage/Magento have a public phpDocumentor archive or why is that important to keep?

from magento-lts.

The arguments offered are in favor of a revert. I have no idea how useful will be those comments in the future.

from magento-lts.

The arguments offered are in favor of a revert. I have no idea how useful will be those comments in the future.

@ADDISON74 actually I said the opposite 😅 and from the emoj reaction I think @elidrissidev agree. @pquerner just asked a question. so let's see if somebody else participates in the discussion.

from magento-lts.

I do not oppose reverting the PR as @sreichel's point is completely valid, but the comments that were removed are not adding much value anyways and the description of the constants as well as their type can be easily inferred from their names. Anyways I'll approve it if someone creates it.

from magento-lts.

What I see its a functionality to copy comments onto multiple variables? My first question would be, is it supported by phpstan for type informations? (or phpstorm?)
But even then I would prefer not having it, as its an uncommon notation many will not understand the meaning of.
But it means we would need to modify the changed files again, as we lost some type and some deprecated annotations (which were intended for multiple entries.
And its a bit odd to have the comments in plural, when the comment is copied into each entry.

Its also documented in their code, although not in their documentation https://github.com/phpDocumentor/ReflectionDocBlock/blob/7b217217725dc991a0ae7b995041cee1d5019561/src/DocBlock.php#L98-L117

from magento-lts.

I can create a PR in like 15 minutes to convert those few "real" tags that we lost (1 deprecated and a couple of "mixed" types) if wanted

from magento-lts.

Does OpenMage/Magento have a public phpDocumentor archive or why is that important to keep?

There is no public one, but maybe private?

With #3552 phpDocumentor looses some descriptions - for absolutly no reason.

I am also pretty sure we had a similar PR years ago, that was closed for same reason. (cant find it)

from magento-lts.

Closed with #3558

from magento-lts.