Giter VIP home page Giter VIP logo

Comments (11)

pquerner avatar pquerner commented on June 25, 2024 1

Well, all this system comes from a time where it wasnt the norm and browsers had troubles with transparent files? I think up to IE11 no IE browser learned to do it or something? So it could be very well just that. :D

from magento-lts.

boesbo avatar boesbo commented on June 25, 2024 1

In the next few days I will propose a patch. I am very clear on the problem. Transparency is simply not managed in the two phases: 1. thumb creation, 2. editor preview url

from magento-lts.

fballiano avatar fballiano commented on June 25, 2024

I'm testing this but I don't think it's the editor's fault because I see the black background already right after uploading it

Screenshot 2024-05-17 alle 10 07 53

at that moment I don't think the new wyswyg has nothing to do with it

from magento-lts.

boesbo avatar boesbo commented on June 25, 2024

I'm testing this but I don't think it's the editor's fault because I see the black background already right after uploading it

Screenshot 2024-05-17 alle 10 07 53 at that moment I don't think the new wyswyg has nothing to do with it

Yes, the problem is in the two files I mentioned above

from magento-lts.

fballiano avatar fballiano commented on June 25, 2024

same thing happening with the old editor on latest v19

Screenshot 2024-05-17 alle 10 12 12

from magento-lts.

boesbo avatar boesbo commented on June 25, 2024

same thing happening with the old editor on latest v19

Screenshot 2024-05-17 alle 10 12 12

Yes, by selling the history I noticed that it is something that we have been carrying with me I imagine since Magento 1.9. Do you think this is intentional behavior? It seems strange.

from magento-lts.

fballiano avatar fballiano commented on June 25, 2024

mmmm I really don't know :-\

all images are always re-saved in order to remove any possible form of "virus" within the image, but to remove transparency I've no idea why

from magento-lts.

pquerner avatar pquerner commented on June 25, 2024

Its imagemagick. Where it gets its settings tho, that I don't know.
I remember something from the TYPO3 days: https://stackoverflow.com/questions/18809692/why-do-imagemagick-based-thumbnail-images-of-pdf-files-in-typo3-have-black-backg https://forge.typo3.org/issues/37060

I dont know if that setting is available to customize from within magento, or if its only sitting in some php.ini file. I know too little about this.

from magento-lts.

boesbo avatar boesbo commented on June 25, 2024

Its imagemagick. Where it gets its settings tho, that I don't know. I remember something from the TYPO3 days: https://stackoverflow.com/questions/18809692/why-do-imagemagick-based-thumbnail-images-of-pdf-files-in-typo3-have-black-backg https://forge.typo3.org/issues/37060

I dont know if that setting is available to customize from within magento, or if its only sitting in some php.ini file. I know too little about this.

That part of the script uses the GD library not ImageMagick:
$image = Varien_Image_Adapter::factory('GD2');

from magento-lts.

pquerner avatar pquerner commented on June 25, 2024

Well this perhaps then
https://stackoverflow.com/questions/5913284/php-gd-transparent-areas-goes-black

(im checking out here, im just googleing stuff anyway)

from magento-lts.

boesbo avatar boesbo commented on June 25, 2024

Yes, this is it. In the two files I wrote at the beginning, transparency management is missing. But it's so obvious that it makes me doubt. It doesn't seem like an oversight.

I can also act by creating a PR, but first I want to better understand if this behavior has a purpose, since it is only visible in the editor.

from magento-lts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.