Giter VIP home page Giter VIP logo

Comments (4)

thorsteinssonh avatar thorsteinssonh commented on June 4, 2024

ok hm, I found that this line in my .env file was the problem TOOLS_VERSION=latest probably for some reason resulting in a bad version of the data import image being used. I had to set this to TOOLS_VERSION=7.0 as is on master for my import of ocean coastlines to work properly. Does tools version lates result in some wrong docker image to be fetched, some image not related to officially latest version?

from openmaptiles.

TomPohys avatar TomPohys commented on June 4, 2024

Hi, sorry for the delay. The OSM Ocean is part of import-data docker in OpenMapTiles-Tools. The docker image v7.0 was built in September 2022 (I know, it is old) with the ocean from that date. The latest image is built from master branch for each commit so it was build in June 2023.

If you need the most fresh data, please build import-data docker (in OpenMapTiles-Tools repo -> make build-import-data) on your local and use that version which will contain the latest ocean. You can also change the version of your local docker build by changing the __init__.py. And after that you can change the version of import-data image in OpenMapTiles docker-compose.yml

from openmaptiles.

thorsteinssonh avatar thorsteinssonh commented on June 4, 2024

@TomPohys thanks so much for the assistance. Yes the issue for me was that I was using a fork that at some point had TOOLS_VERSION=latest set as the docker image choice, and ./quickstart.sh --empty iceland should have ran the image without any baked-in ocean data, if I understood correctly the comments in the quickstart script. However, with the latest image this --empty option was probably somehow not working with that image version.
When I changed the version to 7.0 the --empty option worked and I got the recent update of the coast-lines and the problem was solved.

Thank you also for the hint about building the import image locally, that will definitely help me trouble-shoot any further issues.

from openmaptiles.

thorsteinssonh avatar thorsteinssonh commented on June 4, 2024

Possibly the issue lies with how I set the TOOLS_VERSION in the .env file. If I set it to version 7.0 then all is fine because possibly has a very old version of coastlines as you suggested, the very old version having pretty OK coastlines, before someone messed it up on OSM. What I should have done is build the openmaptiles-import image as you said, but then tag it to a certain version and then make sure that this version tag is being used in the .env config, therefore avoiding fetching a pre-built image that includes out of date data. Will do some tests to make sure this is the problem in fact. Was confusing to me that 7.0 is OK, while latest is not, but in hindsight it makes perfect sense based on the build times of those docker hub images you mentioned in your answer. So, this is almost certainly the issue, I can build from latest, but then I must make sure the .env file TOOLS_VERSION variable uses that image, else some older build will be fetched :p

from openmaptiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.