Giter VIP home page Giter VIP logo

Comments (1)

JustinSGray avatar JustinSGray commented on September 24, 2024

I ran your commit and the baseline run file in the repo and got the same converged value for fan diameter. There have been a few minor tweaks to pyCycle and OpenMDAO itself since the publication of the paper and that seems to have affected the converged values a tiny bit.

at the level of accuracy of this analysis 100.6 vs 100.1 isn't a meaningful change overall. Some of the numerical details in pyCycle mean that we're taking the inverse of some VERY VERY poorly conditioned matrices and that causes a small amount of numerical noise. That, combined with tiny changes to algorithms and small refactors of the code will add up to tiny drifts like that.

Your run is matching what Im seeing, and our current code base is passing all of our regression tests. So you're good.

If you really want it to match the paper exactly, you should roll back to the 1.0 version of pycycle. You'll have to roll back to a version of OpenMDAO that works with that as well. 2.10 should do it.

from pycycle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.