Comments (1)
I ran your commit and the baseline run file in the repo and got the same converged value for fan diameter. There have been a few minor tweaks to pyCycle and OpenMDAO itself since the publication of the paper and that seems to have affected the converged values a tiny bit.
at the level of accuracy of this analysis 100.6 vs 100.1 isn't a meaningful change overall. Some of the numerical details in pyCycle mean that we're taking the inverse of some VERY VERY poorly conditioned matrices and that causes a small amount of numerical noise. That, combined with tiny changes to algorithms and small refactors of the code will add up to tiny drifts like that.
Your run is matching what Im seeing, and our current code base is passing all of our regression tests. So you're good.
If you really want it to match the paper exactly, you should roll back to the 1.0 version of pycycle. You'll have to roll back to a version of OpenMDAO that works with that as well. 2.10 should do it.
from pycycle.
Related Issues (20)
- MFTF example throws error with OpenMDAO 3.1 HOT 1
- Dodecane in janaf.py file
- Unit confusion in species_data.py
- Composition array shape error when using wet air thermo and bleeds
- Problem loading 4.0.0 HOT 1
- Problem checking out version 4.0.0 HOT 3
- Account for fuel LHV in fuel enthalpy HOT 2
- Change breaks existing code HOT 1
- Adapting pyCycle to extra-terrestrial atmosphere HOT 1
- Variable Aliasing in Helper functions
- PSFC units in performance.py
- How to add Combustion efficiency
- Issues related to MAP correction of off-design points HOT 3
- N3ref mudule
- How to visualize a map HOT 4
- 0
- caculation of off-design points for mixed-turbofan
- Issue about whether MAP is automatically scaled
- How do I convert input and output variables
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pycycle.