Comments (7)
This looks like as if the patch was generated with git. Why not simply send a pull request, @erlehmann?
from openraweb.
Matthias Mailänder [email protected] writes:
This looks like as if the patch was generated with git. Why not simply
send a pull request, @erlehmann?
Because the output of “git request-pull” is a bit longer, but not much
more helpful than a simple patch file.
Nils Dagsson Moskopp // erlehmann
http://dieweltistgarnichtso.net
from openraweb.
Welcome to the 21st century where we don't exchange patches via mailing lists anymore. =) Seriously, you will also get credited properly in the commit history if you file a pull request yourself so I would advise that. See https://github.com/OpenRA/OpenRAWeb/pulls
from openraweb.
On Tue, Jan 27, 2015 at 7:57 AM, Matthias Mailänder <
[email protected]> wrote:
Welcome to the 21st century where we don't exchange patches via mailing
lists anymore. =) Seriously, you will also get credited properly in the
commit history if you file a pull request yourself so I would advise that.Well... about that (pretty much all the critical bits of your system are
still developed that way).—
Reply to this email directly or view it on GitHub
#182 (comment).
from openraweb.
I guess git then has a patch import functionality to do that more conveniently?
from openraweb.
It does -- you can apply an mbox trivially.
We're getting way off topic now though :)
Let's:
- Have someone (Taryn?) make a PR for this so our normal workflow can be
used. - Consider the technical merits of the patch.
On the second point, I'm not a huge believer in delivering SHA1sums
alongside packages UNLESS it's all delivered over HTTPS. It doesn't provide
any meaningful assurance of non-tampering otherwise.
I don't think this is actively harmful though, so a tentative +1.
On Tue, Jan 27, 2015 at 9:21 AM, Matthias Mailänder <
[email protected]> wrote:
I guess git then has a patch import functionality to do that more
conveniently?—
Reply to this email directly or view it on GitHub
#182 (comment).
from openraweb.
The problem here is finding a place to put it without messing up the size of the buttons.
It can live on the tooltip, but thats not useful enough to justify its existence (terrible discovery and can't copy the sha1). I'm tempted to say WONTFIX unless somebody has a concrete suggestion on how to make this work.
from openraweb.
Related Issues (20)
- Dark red text on black background is hard to read HOT 5
- Flatpak package for OpenRA is available from the Flathub repository: time to add a general Linux install option HOT 2
- HTTPS for openra.net HOT 11
- Implement authentication backend as a phpBB3 extension. HOT 7
- Integrate pages as custom phpbb page templates HOT 2
- Create a new OpenRAForum project HOT 2
- Nix and Snap packages are available for OpenRA too
- Forum, Badges, ability to give yourself any badge HOT 6
- Add SlackBuilds.org to the list found at https://www.openra.net/download/#linux
- Update some of the ingame screenshots HOT 1
- Add an Opt-out option for Google Analytics HOT 1
- Load disqus plugin on demand HOT 2
- Include jquery library locally HOT 1
- Replace Discord link with new/permanent one
- Update discord invitation link
- The Windows download page only lists the x64 build. HOT 2
- Screenshots ra-base.png and ra-allies02.png feature bounty cash ticks. HOT 1
- my take on the site v2 :)? HOT 3
- OpenRA Website Update Proposal HOT 31
- OpenRA - DNS Issue web page download link doesn't work HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openraweb.