`Jenkinsfile` changed by `UpgradeToJava17` / `RemoveTrailingWhitespace` recipes about rewrite HOT 4 OPEN

I did some digging on this one, and it seems that the problem is here: https://github.com/openrewrite/rewrite/blob/main/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java#L2072. I think it should consider the scope of the quotes.

from rewrite.

Replicated indeed with a test

@Test
void jenkinsFileWithLibrary() {
    rewriteRun(
      groovy(
        """
          @Library("jenkins-shared-libs@my_tag") _
          
          // artifactory standard pipeline
          artifactory()
          """,
        spec -> spec.path("Jenkinsfile")
      )
    );
}

What's interesting here is that it fails whenever the variable name assigned to the library occurs on the same line. If you remove _ from my_tag the test passes; same thing if you replace the last _ with foo. It's not specific to _ either. It fails just the same if you replace _ with a.

from rewrite.

Any updates on this one?

from rewrite.

No updates from my side, although I've also been off for a couple weeks, with some more travel ahead. It seems you've pinpointed the issue already. Are you considering any code changes there already? Or should we tag other folks while I'm out?

from rewrite.