Comments (3)
That helps! Fix should be in
from rewrite.
Thanks for the report! I'm having trouble replicating this issue, as we do have similar tests for this particular case.
The following test passes when added to
@Test
@Issue("https://github.com/openrewrite/rewrite/issues/3832")
void foo() {
rewriteRun(
spec -> spec.expectedCyclesThatMakeChanges(0),
pomXml(
"""
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>com.mycompany.app</groupId>
<artifactId>my-app</artifactId>
<version>1</version>
<properties>
<version.chromedriver>94.0.4606.61</version.chromedriver>
</properties>
<dependencies>
<dependency>
<groupId>selenium-tools</groupId>
<artifactId>chromedriver</artifactId>
<classifier>w64</classifier>
<version>${version.chromedriver}</version>
<type>tar.gz</type>
</dependency>
<dependency>
<groupId>selenium-tools</groupId>
<artifactId>chromedriver</artifactId>
<classifier>x64</classifier>
<version>${version.chromedriver}</version>
<type>tar.gz</type>
</dependency>
</dependencies>
</project>
"""
)
);
}
From the example above, and the wider context of your project, are you then able to reproduce this with a failing test?
from rewrite.
@timtebeek Sorry, I forgot an important point in my issue, these dependencies are declared in dependencyManagement:
<dependencyManagement>
<dependencies>
<dependency>
<groupId>selenium-tools</groupId>
<artifactId>chromedriver</artifactId>
<classifier>w64</classifier>
<version>${version.chromedriver}</version>
<type>tar.gz</type>
</dependency>
<dependency>
<groupId>selenium-tools</groupId>
<artifactId>chromedriver</artifactId>
<classifier>x64</classifier>
<version>${version.chromedriver}</version>
<type>tar.gz</type>
</dependency>
</dependencies>
</dependencyManagement>
from rewrite.
Related Issues (20)
- Declarative Preconditions - Control applicability to ScanningRecipes HOT 6
- Split method signature line into multiple lines based on the length HOT 1
- Add or merge content to yaml file HOT 7
- Create YAML File with remote content HOT 2
- Create a folder HOT 8
- [Windows build from source] Gradle JDK auto-download doesn't work as expected HOT 2
- Unirest 4.x HOT 1
- foo.properties is not print idempotent due to `key==value` HOT 1
- `ChangeType` not working with types provided to the parser using `dependsOn`. HOT 6
- RemoveObjectsIsNull doesn't remove unnecessary parentheses, if it HOT 1
- `AddManagedDependency` should allow version placeholder properties HOT 7
- org.openrewrite.gradle.RemoveDependency does not remove dependency in subproject HOT 3
- Performance issue with classpath scanning HOT 2
- Openrewrite: apply recipe list step by step (to have a proper commit history) HOT 1
- `module-info.java` trips up the JavaParser and Gradle/Maven plugin HOT 35
- Problem with parsing groovy files HOT 1
- RenameVariable does not modify variables referenced through type casts HOT 5
- Groovy Parser Failes on Method Reference Operator :: HOT 3
- Allow custom YAML filenames in YamlParser HOT 4
- There were problems parsing Inner Class HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rewrite.