What version of OpenRewrite are you using? I am using <ul dir

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

`AddOrUpdateAnnotationAttribute` throws an error when adding a `class` as `attributeValue` about rewrite HOT 2 OPEN

JohannesRabauer commented on June 22, 2024

`AddOrUpdateAnnotationAttribute` throws an error when adding a `class` as `attributeValue`

from rewrite.

Comments (2)

JohannesRabauer commented on June 22, 2024 1

Thanks @timtebeek. I tried to do a minimal test with PR.

from rewrite.

timtebeek commented on June 22, 2024

Hi @JohannesRabauer ! Looks like you're running up against a limitation where AddOrUpdateAnnotationAttribute can only update literal values for now.

rewrite/rewrite-java/src/main/java/org/openrewrite/java/AddOrUpdateAnnotationAttribute.java

Lines 97 to 107 in 516c70b

 // First assume the value exists amongst the arguments and attempt to update it 

 AtomicBoolean foundAttributeWithDesiredValue = new AtomicBoolean(false); 

 final J.Annotation finalA = a; 

 List<Expression> newArgs = ListUtils.map(currentArgs, it -> { 

 if (it instanceof J.Assignment) { 

 J.Assignment as = (J.Assignment) it; 

 J.Identifier var = (J.Identifier) as.getVariable(); 

 if (attributeName == null || !attributeName.equals(var.getSimpleName())) { 

 return it; 

 } 

 J.Literal value = (J.Literal) as.getAssignment();

Your case of adding an attribute that's a class had not yet been reported; It could likely be added by updating the recipe itself. Starting with a draft PR with a failing test case of what you'd like to see is a great way to get this started, if you're up for that.

from rewrite.

`AddOrUpdateAnnotationAttribute` throws an error when adding a `class` as `attributeValue` about rewrite HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// First assume the value exists amongst the arguments and attempt to update it
	AtomicBoolean foundAttributeWithDesiredValue = new AtomicBoolean(false);
	final J.Annotation finalA = a;
	List<Expression> newArgs = ListUtils.map(currentArgs, it -> {
	if (it instanceof J.Assignment) {
	J.Assignment as = (J.Assignment) it;
	J.Identifier var = (J.Identifier) as.getVariable();
	if (attributeName == null \|\| !attributeName.equals(var.getSimpleName())) {
	return it;
	}
	J.Literal value = (J.Literal) as.getAssignment();