Comments (5)
I think @siteshwar meant the case where both branches point to the same commit object, which is the most common case in this project. I fully agree that it makes sense to re-run the tests if main
refers to a different commit (or even a different tree) after the merge.
from openscanhub.
This isn't the right thing to do. Why would you want to accomplish such a behavior?
I can recall quite a few moments when CI on PR passed, and once PR got merged, it failed for various reasons (the PR branch was missing some commits from the main
, etc.).
A good example is tests and test coverage. You generally want to run tests and upload test coverage on pull_request
to measure changes in coverage with changes from PR. Once merged, you want to run it again to measure and update the overall test coverage of the project.
But if you want to accomplish this thing. The only option is to run workflows only on pull_request
or push
events.
from openscanhub.
@siteshwar Do you have any updates?
from openscanhub.
@siteshwar Ping?
from openscanhub.
@siteshwar Ping?
Sorry, I have not taken a look at this issue and its not my priority for now.
from openscanhub.
Related Issues (20)
- hub: user with a name containing the `/` character cannot be modified in Django Admin HOT 3
- client: change default hub url to `openscanhub.fedoraproject.org` HOT 8
- hub: merge `errata` and `scan` Django applications
- hub: do not use `noarch` as the default worker architecture
- client: rename `shortcuts` and `common` modules to something more descriptive
- Fedora PoC feedback HOT 4
- Web interface: design/accessibility issues HOT 2
- hub: merge code in `hub/scan/scanner.py` responsible for scheduling of build tasks
- hub: actions in scan admin should change task states properly
- hub: tweak configration of systemd units and timers
- Allow passing SRPM as URL HOT 10
- containers: dummy SMTP server does not log to file
- hub: domain name for notification e-mails should be configurable
- Shall we remove `Hostname` field from e-mail notifications? HOT 1
- Shall we remove support for CentOS Stream 8? HOT 7
- ci: deprecation warning in the CodeQL job
- hub: separate internal features from the rest of the code base HOT 3
- client: searching is broken/unintuitive when multiple options are specified
- tests: groups tests in dedicated module
- How shall we mark false positives? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openscanhub.