Giter VIP home page Giter VIP logo

Comments (5)

kdudka avatar kdudka commented on September 24, 2024 2

I think @siteshwar meant the case where both branches point to the same commit object, which is the most common case in this project. I fully agree that it makes sense to re-run the tests if main refers to a different commit (or even a different tree) after the merge.

from openscanhub.

jamacku avatar jamacku commented on September 24, 2024

This isn't the right thing to do. Why would you want to accomplish such a behavior?

I can recall quite a few moments when CI on PR passed, and once PR got merged, it failed for various reasons (the PR branch was missing some commits from the main, etc.).

A good example is tests and test coverage. You generally want to run tests and upload test coverage on pull_request to measure changes in coverage with changes from PR. Once merged, you want to run it again to measure and update the overall test coverage of the project.

But if you want to accomplish this thing. The only option is to run workflows only on pull_request or push events.

from openscanhub.

lzaoral avatar lzaoral commented on September 24, 2024

@siteshwar Do you have any updates?

from openscanhub.

lzaoral avatar lzaoral commented on September 24, 2024

@siteshwar Ping?

from openscanhub.

siteshwar avatar siteshwar commented on September 24, 2024

@siteshwar Ping?

Sorry, I have not taken a look at this issue and its not my priority for now.

from openscanhub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.