Giter VIP home page Giter VIP logo

Comments (6)

YunWZ avatar YunWZ commented on May 25, 2024
apiVersion: fault-tolerance.opensergo.io/v1alpha1
kind: FaultToleranceRule
metadata:
  name: my-rule
  namespace: prod
  labels:
    app: my-app # 规则配置生效的应用名

建议将匹配生效应用名部分(app: my-app)放到spec中,例如.spec.selector或者.spec.selector. matchLabels

意义:

  1. metadata部分应当只用于设置当前CR(容错治理规则)的元数据;
  2. 保持和其他CRD规范的语义一致,避免产生歧义,易于使用--例如Istio中的Gateway,k8s中的Deployment

from opensergo-specification.

sczyh30 avatar sczyh30 commented on May 25, 2024

@YunWZ Good idea. Would you like to contribute a PR to improve it?
https://github.com/opensergo/opensergo-specification/blob/main/specification/zh-Hans/fault-tolerance.md

from opensergo-specification.

YunWZ avatar YunWZ commented on May 25, 2024

@YunWZ Good idea. Would you like to contribute a PR to improve it? https://github.com/opensergo/opensergo-specification/blob/main/specification/zh-Hans/fault-tolerance.md

Of course

from opensergo-specification.

halfrost avatar halfrost commented on May 25, 2024

I'm confused about there parts:

  1. What is kind of HttpRequestFallbackAction. In the sentinel go document, there are only five type of rules, RateLimitStrategyThrottlingStrategyConcurrencyLimitStrategyCircuitBreakerStrategyAdaptiveOverloadProtectionStrategy. How can we declare such a type?
  2. limitMode is not implemented in the current code, right? For example, in ConcurrencyLimit, use isolation to generate a rule. But in this rule, it doesn't have limitMode attribute.
  3. The slowConditions field also does not exist in currently code, right?

from opensergo-specification.

sczyh30 avatar sczyh30 commented on May 25, 2024

@halfrost For 1, you may refer to the structure of FaultToleranceRule. HttpRequestFallbackAction is a kind of FallbackAction (not a Strategy), which describes the fallback HTTP response when the associated strategies are triggered.

For 2 and 3, which code repo are you referring to? These fields have been already defined in https://github.com/opensergo/opensergo-java-sdk/blob/main/src/main/proto/fault_tolerance/v1/fault_tolerance.proto

from opensergo-specification.

halfrost avatar halfrost commented on May 25, 2024

@sczyh30 For 2 and 3, I didn't find these 2 attribute fields in sentinel-go's code.

from opensergo-specification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.