CI failure due to tito exception - test_pull_request_origin_extended_conformance_gce_39 about aos-cd-jobs HOT 25 CLOSED

Great, thanks for the retest. It merged, so all must be well.

from aos-cd-jobs.

/cc @sdodson

Does the tag exist in the repo itself? Or is this an AMI thing? Is the tag present in some other branch?

from aos-cd-jobs.

The tag was created yesterday - https://github.com/openshift/openshift-ansible/releases/tag/openshift-ansible-3.9.31-1

from aos-cd-jobs.

@kwoodson what's up with that tag? We need to use tito so that the specfile gets bumped at the same time as tag creation.

I just tagged 3.9.32-1 to clean this up.

from aos-cd-jobs.

Did this to force 3.9.32, but normally you don't need to specify the version.

tito tag --use-version=3.9.32
Tagging new version of openshift-ansible: 3.9.30-1 -> 3.9.32-1

Created tag: openshift-ansible-3.9.32-1
   View: git show HEAD
   Undo: tito tag -u
   Push: git push origin && git push origin openshift-ansible-3.9.32-1

from aos-cd-jobs.

@sdodson I didn't do anything out of the ordinary. How do those tags get created? I merged a pr for Azure.

from aos-cd-jobs.

This has fixed the problem, thanks!

from aos-cd-jobs.

@jupierce I think something is going on with tagging, these tags all tag just a random commit with no corresponding specfile version bump is that expected? This causes the origin ci processes to attempt a local tag that points at a version that may already exist.

https://github.com/openshift/openshift-ansible/releases/tag/openshift-ansible-3.9.31-1
https://github.com/openshift/openshift-ansible/releases/tag/openshift-ansible-3.10.0-0.67.0
https://github.com/openshift/openshift-ansible/releases/tag/openshift-ansible-3.10.0-0.66.0
https://github.com/openshift/openshift-ansible/releases/tag/openshift-ansible-3.10.0-0.65.0

Where as this one looks as expected
https://github.com/openshift/openshift-ansible/releases/tag/openshift-ansible-3.10.0-0.64.0

I'd initially thought that @kwoodson tagged something randomly but seeing that one of the bad tags references a commit I made and I don't recall creating it I think the CI jobs must be doing something weird.

from aos-cd-jobs.

@sdodson CD was working on moving openshift-ansible to be a "normal" RPM (just like other components). Other components don't get their spec file incremented right now.

@tbielawa @adammhaile @markllama - This is resulting from new oit based openshift-ansible RPM build. oit will need to update the spec file for this component in order to not break CI.

from aos-cd-jobs.

s/normal/abnormal/ FTFY
The fact that we're producing builds with versions and tags that aren't reflected in the specfile is an aberration that only OpenShift has.

@stevekuznetsov I guess one way we could resolve this is to force CI jobs to generate some tag that is never going to conflict like 3.10.0-90000

from aos-cd-jobs.

@sdodson I think per @jupierce this is a regression introduced when we switched the openshift-ansible RPM build from custom code in Groovy to use the OIT rpms:build task. I'll look back at the refactored code and see If I can find what logic did this correctly before.

from aos-cd-jobs.

@sdodson sure, we could make that tag. IIRC it's just in the tito call in the job

from aos-cd-jobs.

PR: https://github.com/openshift/aos-cd-jobs/pull/1461/files

from aos-cd-jobs.

PR merged. Need confirmation.

from aos-cd-jobs.

@stevekuznetsov @sdodson close this out if you decide the fix did the 👍 needful

from aos-cd-jobs.

It did not, it has broken things again.

from aos-cd-jobs.

@tbielawa
It looks like setting the release strips the '.el7' from the RPM Release. The build/tag step produces openshift-ansible-3.10.1-9999.git.0.3c903c2 but the install wants openshift-ansible-3.10.1-9999.git.0.3c903c2.el7

from aos-cd-jobs.

@sdodson Updated with #1462

from aos-cd-jobs.

It's still failing - https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_install/12241/consoleFull#198243902558b6e51eb7608a5981914356

from aos-cd-jobs.

@jpeeler Can't explain why the original push didn't work, but I pushed this time, checked that the job was corrected and it is getting further now: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_install/12242/consoleFull

from aos-cd-jobs.

Alright then folks, is there general consensus now that this is working? Nobody seeing anything "wrong" or mistagged or generally 😕 ? Ready to close this issue out?

@stevekuznetsov @sdodson @jpeeler

from aos-cd-jobs.

jpeeler's tests and several initiated by @jupierce overnight ran to completion, built and used the openshift-ansible package. The fix was to force a tag during the test build that had previously been forced during oit.

from aos-cd-jobs.

@jpeeler can you verify?

from aos-cd-jobs.

Yes, I'm not seeing any issues related to the tagging any more.

from aos-cd-jobs.

/close

from aos-cd-jobs.