Giter VIP home page Giter VIP logo

Comments (5)

metalmatze avatar metalmatze commented on July 18, 2024

Hey @ulikl.
Thanks for raising the issue. The original rule is from another project: https://github.com/kubernetes-monitoring/kubernetes-mixin

I'm not entirely sure why we did not go with kube_node_status_capacity_pods but looking at it right now, it seems good to me.
Would you mind creating another Issue or PR over at the other repository?
Feel free to /cc @metalmatze there in the description.

Here is the line that would need to be changed:
https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/9069b2c1be0ce32f63f9a01c4a4f8d69bc4e37d5/alerts/system_alerts.libsonnet#L70

from cluster-monitoring-operator.

ulikl avatar ulikl commented on July 18, 2024

I opened the Issue kubernetes-monitoring/kubernetes-mixin#223 there.

There will only be an improvement for Kubernetes 1.14 and higher.

from cluster-monitoring-operator.

simonpasquier avatar simonpasquier commented on July 18, 2024

The alert has been enhanced upstream and it takes node capacity into account since 4.3 at least.

from cluster-monitoring-operator.

simonpasquier avatar simonpasquier commented on July 18, 2024

/close

from cluster-monitoring-operator.

openshift-ci-robot avatar openshift-ci-robot commented on July 18, 2024

@simonpasquier: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-monitoring-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.