Giter VIP home page Giter VIP logo

Comments (8)

smarterclayton avatar smarterclayton commented on July 18, 2024 1

Jobs failing doesn't mean the cluster is broken. There are lots of pods that can run to completion and exit with status code 0 as part of normal operation.

In this case, this is ci jobs running on the cluster that use restart=Never pods. We'll always have some level of failing builds on a cluster as well (openshift builds run as pods).

from cluster-monitoring-operator.

jwforres avatar jwforres commented on July 18, 2024

Can confirm - seeing this on some pods on free-int as well

from cluster-monitoring-operator.

s-urbaniak avatar s-urbaniak commented on July 18, 2024

I believe this would be tricky today as restartPolicy is not passed through via the kube-state-metrics I believe (/cc @brancz for verification).

What status are those job pods exactly in and what failure/exit mode is provoking those pods to be alerted? Looking at the alerting expression all job pods which exit with Succeeded should not fire any alerts:

sum by(namespace, pod) (kube_pod_status_phase{job="kube-state metrics",phase!~"Running|Succeeded"}) > 0

Wouldn't it make more sense to modify those job pods to exit with a Succeeded status?

from cluster-monitoring-operator.

smarterclayton avatar smarterclayton commented on July 18, 2024

It's likely that we could constrain this to only system namespaces kube-* / openshift-*, in which case the check is probably fine for now.

from cluster-monitoring-operator.

brancz avatar brancz commented on July 18, 2024

Yes we have limiting things to a list of namespaces already on our radar: kubernetes-monitoring/kubernetes-mixin#56

I think we're going to have to do this before code freeze, as it produces too much noise.

from cluster-monitoring-operator.

brancz avatar brancz commented on July 18, 2024

For the time being this was fixed by kubernetes-monitoring/kubernetes-mixin#70, we may be able to improve this a bit more in the future but for now it's not producing false positives.

We'll need to update the jsonnet dependency to get this.

from cluster-monitoring-operator.

openshift-bot avatar openshift-bot commented on July 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from cluster-monitoring-operator.

s-urbaniak avatar s-urbaniak commented on July 18, 2024

The referenced mixins have been long merged, hence closing out.

from cluster-monitoring-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.