Comments (4)
The best known example is
This condition shouldn't be just silently ignored.
image-registry/pkg/dockerregistry/server/blobdescriptorservice.go
Lines 46 to 48 in d5a3219
This error should be logged as well. And this new log message should supersede the previous one.
And here we can see abstraction leak. Sometimes this execution flow is related to pullthrough, sometimes is not. Most likely it will require refactoring to get better logs.
from image-registry.
from image-registry.
thanks @legionus @dmage it sounds like a promising approach, I look forward to discussing it further when i'm back in the office
from image-registry.
Fixed by #110.
from image-registry.
Related Issues (20)
- Request ID is inconsistent HOT 4
- Update regions HOT 1
- Problems with non AWS-S3 storage backend HOT 1
- Future Release Branches Frozen For Merging | branch:release-4.17 branch:release-4.18 HOT 3
- is it possible to add "app Item" to Catalog??? HOT 3
- [Need help] Is openshift internal registry has token service api ? HOT 3
- error getting secrets: <nil> HOT 1
- redirect parameter not working HOT 10
- registry fail to start (4.2-2019-08-08-070705) HOT 3
- Setup golangci-lint
- openshift create ca server certificate for docker registry HOT 2
- Notifications/Webhooks for repository notifications HOT 2
- OCP 4.2 ImageRegistry fails with nfs-storage on s390x HOT 7
- Openshift 4.3 - Getting timeout trying to log into image-registry using podman HOT 3
- [Need help]How to get a username/password (do not refresh)who has the admin permission for openshift registry HOT 5
- Failed to create image registry with Swift storage on s390x HOT 7
- CRC Image Registry docker login issue on Windows - 127.0.0.1:80 connection refused
- allowedRegistriesForImport Behavior HOT 4
- DELETE operation is unsupported HOT 1
- OKD doc link do not work HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image-registry.