Support for podman/buildah about imagebuilder HOT 12 CLOSED

Could you describe what fails?

from imagebuilder.

Here's the output I'm getting:

$ make images
imagebuilder --allow-pull -t registry.svc.ci.openshift.org/ocp/4.2:cluster-kube-controller-manager-operator -f ./Dockerfile.rhel7 .
Get http://unix.sock/images/registry.svc.ci.openshift.org/ocp/builder:golang-1.12/json: dial unix /var/run/docker.sock: connect: no such file or directory

I did pull both images as mentioned in the README, but that clearly did not help.

from imagebuilder.

Wrt to my question at All Systems Go, I was thinking of this issue here @rhatdan @mrguitar

from imagebuilder.

This version of imagebuilder has not been ported to use Buildah.
@nalind Is this possible, or do we only have it vendored within OpenShift?

from imagebuilder.

Even if we fix the docker socket issue, IIRC imagebuilder uses docker's HTTP api - https://github.com/fsouza/go-dockerclient (last I checked!).

I am not sure if we will have implement those bits in varlink or something else.

from imagebuilder.

This version of imagebuilder has not been ported to use Buildah.

huh, so this repo isn't the upstream? Can we get that vendored version on a branch in this repo?

from imagebuilder.

So far as I know, this is the home repository for imagebuilder.

The repository includes three things: a library that can parse Dockerfiles and use an object that implements its Executor interface to perform a build (that's github.com/openshift/imagebuilder), an implementation of Executor that uses github.com/fsouza/go-dockerclient to do the work with the help of a dockerd daemon (that's github.com/openshift/imagebuilder/dockerclient), and the CLI tool that pairs them together (that's github.com/openshift/imagebuilder/cmd/imagebuilder).

The buildah libraries provide an implementation of Executor that its CLI, and podman's, combine with imagebuilder's main library to allow them to build images using Dockerfiles. While I think we could graft that into the imagebuilder CLI (give or take a couple of features), doing so would add a lot of dependencies (ballpark it growing from 14MB to about 35MB), all of them Linux-specific.

I like the idea of an Executor that would use varlink, though from https://github.com/containers/libpod/blob/master/API.md it's not clear to me if it provides all of the functionality that Executor would need to be able to use.

from imagebuilder.

IIUC that means the imagebuilder CLI does not work with buildah, but there is some way to do a buildah build with imagebuilder programmatically?

from imagebuilder.

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from imagebuilder.

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from imagebuilder.

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

from imagebuilder.

@openshift-bot: Closing this issue.

from imagebuilder.