Only send needed files as Docker context (use Buildkit) about imagebuilder HOT 8 CLOSED

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from imagebuilder.

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from imagebuilder.

can a maintainer pls take a look at this?

from imagebuilder.

@rhatdan @TomSweeneyRedHat

from imagebuilder.

imagebuilder uploads what it needs to in order to handle ADD and COPY instructions as it goes along.

mkdir tmp
dd if=/dev/urandom of=tmp/bigfile bs=1M count=10K
touch tmp/smallfile
cat > tmp/Dockerfile << EOF
FROM busybox
ADD smallfile /
EOF
imagebuilder ./tmp
docker build ./tmp

We ended up forking the Dockerfile parser around #125 to avoid pulling in other dependencies.

from imagebuilder.

@djbrown does @nalind's comment answer your question? If so, can you close this issue?

from imagebuilder.

Not really, but when digging deeper to explain my problem I found a workaround/solution.
Yet this issue might still be eligible.

My original concern was build perfomance when using binary remote build.
I was using the OCP server as "docker service/host", sending my local files as docker context via oc start-build --from-dir=".".
This would upload the whole directory which took a lot of time.

In the docs under Build Inputs > Binary (Local) Source I found the --from-archive option.
This way I can improve the performance manually.

Ideally the oc command would analyze the Dockerfile definition beforehand and only upload needed files, but I think the command wasn't design for that. Is this something you would consider implementing?
If this is the wrong component/repo for this issue I will move it.
If this is an overall unreasonable request (by design) then you or I may close this issue.

P.S. Also I discovered that in moby/moby@c9ebd2f builder/dockerfile/parser/ was actually removed/replaced by moby/buildkit/frontend/dockerfile/parser/. Maybe BuildKit is more isolated and could be included with less unused dependencies.

from imagebuilder.

The logic in imagebuilder only gets called into play in the build pod once it's running; it is not called by oc start-build.

from imagebuilder.