ADD foo /usr/bin nukes /usr/bin about imagebuilder HOT 7 CLOSED

https://docs.docker.com/engine/reference/builder/#add seems to be wrong about this (does not look changed since docker 1.13):
If <dest> does not end with a trailing slash, it will be considered a regular file and the contents of <src> will be written at <dest>.

This is not specific to /usr/bin, the same treatment seems to occur with any pre-existing directory on the image.

from imagebuilder.

Hrm, this works for me.

from imagebuilder.

Tested with the following:

FROM centos:7
ADD script /usr/bin
RUN find /usr/bin

Puts script into /usr/bin/script

FROM busybox
ADD script /usr/bin
RUN find /usr/bin

puts script at /usr/bin

fedora:

FROM fedora:28
ADD script /usr/bin
RUN find /usr/bin

Fails as described.

from imagebuilder.

docker run fedora:28 find /usr/bin
container_linux.go:247: starting container process caused "exec: \"find\": executable file not found in $PATH"
docker: Error response from daemon: oci runtime error: container_linux.go:247: starting container process caused "exec: \"find\": executable file not found in $PATH".
ERRO[0000] error getting events from daemon: net/http: request canceled

I think there is something off about the fedora 28 image

from imagebuilder.

Oh, it doesn't have find.

Ok, i have a reproducer. Docker is checking the destination path. We can't do that as easily as the daemon. Going to have to look at options.

from imagebuilder.

Fixed, please test it out.

from imagebuilder.

Found another bug in #86

from imagebuilder.