Giter VIP home page Giter VIP logo

Comments (7)

pbmoses avatar pbmoses commented on June 28, 2024 1

I actually have it fixed I believe but am in the final testing stage (accidentally submitted PR then cancelled.) The same also seems to be true for ingress config

from ingress-node-firewall.

pbmoses avatar pbmoses commented on June 28, 2024 1

ah, I simply meant the ingress is the same, CRD shows MinItem:1

kubebuilder:validation shows 1 but we can still deploy with no ingress definition, which can be confusing to end user/admin

	// ingress is a list of ingress firewall policy rules.
	// +kubebuilder:validation:Required
	// +kubebuilder:validation:MinItems:=1
	Ingress []IngressNodeFirewallRules `json:"ingress,omitempty"

// ingress is a list of ingress firewall policy rules.

from ingress-node-firewall.

msherif1234 avatar msherif1234 commented on June 28, 2024

Thanks @pbmoses for opening this issue I will investigate and fix

from ingress-node-firewall.

msherif1234 avatar msherif1234 commented on June 28, 2024

/assign @msherif1234

from ingress-node-firewall.

msherif1234 avatar msherif1234 commented on June 28, 2024

early on we were thinking of using empty list to enable on all interfaces but we decided half way to be very specific and include all involved interfaces to avoid any harm with that having omitempty in this field is not valid

from ingress-node-firewall.

msherif1234 avatar msherif1234 commented on June 28, 2024

for the config I think you are referring to rule like this which is valid

 ingress:
  - sourceCIDRs:
       - 172.16.0.0/12
    rules:
    - order: 10
      action: Deny

pls confirm is this what u were referring to ?

from ingress-node-firewall.

pbmoses avatar pbmoses commented on June 28, 2024

additional info: related issues

from ingress-node-firewall.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.