Giter VIP home page Giter VIP logo

Comments (7)

gabemontero avatar gabemontero commented on July 19, 2024

hey @stevekuznetsov - Given the contents of that message, starting with the ; appearing, then the AbortException is thrown here

At that point, how the UI renders is in the hands of the pipeline code, and beyond the scope of the openshift client plugin. Perhaps it has something to do with the use of step { ... script { ...

And throwing the Abort per everything we've seen is the right thing to do.

If there is doubt that the abort exception is being thrown, and if this is at all reproducible, you can temporarily but a try/catch around the apply to confirm.

@jupierce - any additional thoughts or items you think I might be overlooking?

from jenkins-client-plugin.

stevekuznetsov avatar stevekuznetsov commented on July 19, 2024

If this is an error on the GUI side of things -- where should I report it?

from jenkins-client-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

Per https://wiki.jenkins-ci.org/display/JENKINS/Blue+Ocean+Plugin I would follow the "Issue tracking" link which takes you to https://issues.jenkins-ci.org and the blue ocean category.

Aside from confirming the AbortException was thrown which I mentioned previously beforehand, as a heads up, I bet they are going to ask for a simplified test case for them to repro with, full logs, etc.

from jenkins-client-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

Going to go ahead and close ... of course reopen if new evidence like the AbortException not getting thrown emerges.

from jenkins-client-plugin.

jupierce avatar jupierce commented on July 19, 2024

It looks like something is catching the exception and printing it out instead of allowing the job to fail.

The message you are seeing is constructed here and just the content of the AbortException: https://github.com/openshift/jenkins-client-plugin/blob/master/src/main/resources/com/openshift/jenkins/plugins/OpenShiftDSL.groovy#L729

This has traditionally been enough to stop a pipeline from executing. Perhaps declarative syntax handles exceptions differently?

What happens if you put an
error( "This should stop the job")
in your script somewhere? Is that exception swallowed as well?

ref: https://jenkins.io/doc/pipeline/steps/workflow-basic-steps/#code-error-code-error-signal

from jenkins-client-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

thanks @jupierce - the OpenShiftDSL.groovy link you posted lines up with the one I posted in #32 (comment)

some goes wrt the new syntax and possible exception handling ...i.e. step { .. script {...

so all good on those points (thanks again) :-)

Didn't know about error(...) ... thanks for the tip / I agree a good sanity check for @stevekuznetsov to try.

If error(...) kills the job and throwing AbortException does not, then I suppose we use this bug to switch client plugin and OpenShiftDLS.groovy to use error(...) .... agree ?

from jenkins-client-plugin.

gabemontero avatar gabemontero commented on July 19, 2024

Though it is interesting that the doc for that step says: You can also just throw new Exception(), but this step will avoid printing a stack trace.

from jenkins-client-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.