Comments (9)
gabemontero
commented on July 21, 2024
1
On Wed, May 17, 2017 at 11:18 AM, Oleg Popov ***@***.***> wrote:
@gabemontero <https://github.com/gabemontero> It seems that all
parameters work fine. I have checked all of them :) Thanks for your fast
response/improvement :)
Sounds good. Glad to help. Thanks for testing.
PS. Are there any restrictions of number of arguments ?
No. It is an unbounded Java List.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADbadM0KWVb9YJYjd3zlYLMbUHFwUwolks5r6w_SgaJpZM4NcDa6>
.
from jenkins-plugin.
gabemontero
commented on July 21, 2024
hi @livelace - I need to clarify what you mean by "support variables"
Are you saying you would like to define job build parameters / env vars and then reference them as the pod name, container name, arguments values you supply to the job definition?
i.e. for the pod name, you seed the job with ${MY_POD_NAME}, and then you define that as a build param for the job?
If so, while we are generally shutting down new development with this plugin in favor of https://github.com/openshift/jenkins-client-plugin (where you should be able to use $env.MY_POD_NAME), this change is pretty small / trivial (and one could argue should have been done originally), and I might be able to squeeze it in, pending agreement from @bparees
from jenkins-plugin.
bparees
commented on July 21, 2024
@gabemontero if it's trivial to add support for this to all the arg fields for the plugin steps (not just this step), it's probably worth doing. if it's a one off for this step, it's just a slippery slope...
from jenkins-plugin.
livelace
commented on July 21, 2024
Are you saying you would like to define job build parameters / env vars and then reference them as the pod name, container name, arguments values you supply to the job definition?
i.e. for the pod name, you seed the job with ${MY_POD_NAME}, and then you define that as a build param for the job?
Yes, absolutely.
If so, while we are generally shutting down new development with this plugin in favor of https://github.com/openshift/jenkins-client-plugin (where you should be able to use $env.MY_POD_NAME), this change is pretty small / trivial (and one could argue should have been done originally), and I might be able to squeeze it in, pending agreement from @bparees
Yes, it's a trivial change and we need it :) Yes, we use DSL plugin, thanks for that, but DSL/pipeline/groovy are not so easy for newbies and this plugin allows very quickly assemble a simple (relative complex) task/deployment/service. For instance - we use DSL plugin at the top of complex workflows, those contains numerous dependencies of CI , but at the bottom layers lay more simple tasks, which are created by this plugin.
from jenkins-plugin.
gabemontero
commented on July 21, 2024
On Tue, May 16, 2017 at 1:58 PM, Ben Parees ***@***.***> wrote:
@gabemontero <https://github.com/gabemontero> if it's trivial to add
support for this to all the arg fields for the plugin steps (not just this
step), it's probably worth doing. if it's a one off for this step, it's
just a slippery slope...
It is just a portion of this step @bparees. In general we support var
substitution for config fields, including several of the "base" params in
the oc exec step.
The pod/container/args fields specific to oc exec were omitted.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADbadKrDrLfy9QmRVt1bdaLTa6G6Lox3ks5r6ePEgaJpZM4NcDa6>
.
from jenkins-plugin.
gabemontero
commented on July 21, 2024
On Tue, May 16, 2017 at 2:09 PM, Oleg Popov ***@***.***> wrote:
Are you saying you would like to define job build parameters / env vars
and then reference them as the pod name, container name, arguments values
you supply to the job definition?
i.e. for the pod name, you seed the job with ${MY_POD_NAME}, and then you
define that as a build param for the job?
Yes, absolutely.
OK thanks for the confirmation. Given the response from @bparees, I'll see
about adding this in the next few days.
… If so, while we are generally shutting down new development with this
plugin in favor of https://github.com/openshift/jenkins-client-plugin
(where you should be able to use $env.MY_POD_NAME), this change is pretty
small / trivial (and one could argue should have been done originally), and
I might be able to squeeze it in, pending agreement from @bparees
<https://github.com/bparees>
Yes, it's a trivial change and we need it :) Yes, we use DSL plugin,
thanks for that, but DSL/pipeline/groovy are not so easy for newbies and
this plugin allows very quickly assemble a simple (relative complex)
task/deployment/service. For instance - we use DSL plugin at the top of
complex workflows, those contains numerous dependencies of CI , but at the
bottom layers lay more simple tasks, which are created by this plugin.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADbadOojGsS-Jc5eZEhk_O76IkfqOU6Iks5r6eZ3gaJpZM4NcDa6>
.
from jenkins-plugin.
livelace
commented on July 21, 2024
Thanks, guys :)
from jenkins-plugin.
gabemontero
commented on July 21, 2024
@livelace if you can try out the pre-release version of this change at https://ci.openshift.redhat.com/jenkins/view/All/job/openshift-pipeline-plugin/36/s3/download/openshift-pipeline.hpi
from jenkins-plugin.
livelace
commented on July 21, 2024
@gabemontero It seems that all parameters work fine. I have checked all of them :) Thanks for your fast response/improvement :)
PS. Are there any restrictions of number of arguments ?
from jenkins-plugin.
Related Issues (20)
- Patch / Update resources HOT 9
- jenkins template using spec.clusterIP instead of spec.portalIP HOT 2
- Build output sometimes not shown in jenkins console output HOT 2
- Deployments don't work HOT 3
- Environment Variables don't respect Parameterised Builds HOT 6
- Timeout of builds HOT 3
- Unable to do openshiftTag() in pipeline HOT 1
- BUG: "Test connection" always returns "Connections successful" HOT 11
- BUG: OpenshiftExec ignores timeout HOT 12
- Confusing print statement if openshiftVerifyDeployment fails HOT 1
- okhttp binary changes break plugin when others installed HOT 11
- Externalize the CERT_FILE = "/run/secrets/kubernetes.io/serviceaccount/ca.crt"; HOT 7
- Issue with Jenkin's Verify Build OpenShift plug-in functionality HOT 9
- Declarative pipeline support? HOT 4
- openshift-client-plugin really still a "tech preview" ? HOT 3
- Jenkins throws an error when using the openhiftBuild with the buildConfig parameter HOT 3
- Resulting GDSL is Broken HOT 2
- openshiftBuild should support binary build type. HOT 10
- Add deprecation warning and link to new plugin as first thing in repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jenkins-plugin.