Giter VIP home page Giter VIP logo

Comments (13)

sferich888 avatar sferich888 commented on June 26, 2024 1

@palonsoro see #327 (comment)

from must-gather.

openshift-bot avatar openshift-bot commented on June 26, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from must-gather.

sferich888 avatar sferich888 commented on June 26, 2024

#129 I think addresses this.
Other improvements are being made with #327

from must-gather.

sferich888 avatar sferich888 commented on June 26, 2024

/close

from must-gather.

openshift-ci avatar openshift-ci commented on June 26, 2024

@sferich888: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from must-gather.

oarribas avatar oarribas commented on June 26, 2024

@sferich888 , #129 is not addressing this, as the version file in latest must-gather versions is still not showing information about the version.

The version file in a must-gather from an OCP 4.11 cluster only shows 4.0-art-dev:

$ oc version
Client Version: 4.11.9
Server Version: 4.11.9
Kubernetes Version: v1.24.0+dc5a2fd

$ cat version 
openshift/must-gather
4.0-art-dev

There is no info about the version of the must-gather image used to collect it.

from must-gather.

palonsoro avatar palonsoro commented on June 26, 2024

A version obtained at the must-gather image will never reflect the version used to run oc adm must-gather command but the version of oc inside the must-gather image.

Writing that version doesn't have greatest value, because it is imposed by the cluster version (the must-gather image is derived from cli image of the same release, so oc version is imposed by the release).

If the client version is desired, this should be proposed and implemented in oc repo

from must-gather.

oarribas avatar oarribas commented on June 26, 2024

This issue is not for the oc version used for running the command, but the version of the must-gather script used.
The current version script in the must-gather (https://github.com/openshift/must-gather/blob/release-4.11/collection-scripts/version) is not working properly and only shows 4.0-art-dev (and not the digest of the image, the PR of the script, or nothing else):

$ cat version 
openshift/must-gather
4.0-art-dev

/reopen

#327 could be the solution for this issue.

from must-gather.

openshift-ci avatar openshift-ci commented on June 26, 2024

@oarribas: Reopened this issue.

In response to this:

This issue is not for the oc version used for running the command, but the version of the must-gather script used.
The current version script in the must-gather (https://github.com/openshift/must-gather/blob/release-4.11/collection-scripts/version) is not working properly and only shows 4.0-art-dev (and not the digest of the image or anything else):

$ cat version 
openshift/must-gather
4.0-art-dev

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from must-gather.

sferich888 avatar sferich888 commented on June 26, 2024

@sanchezl if you think #327 fixes this issue; can you plean link and close upon merger?

from must-gather.

openshift-bot avatar openshift-bot commented on June 26, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from must-gather.

sferich888 avatar sferich888 commented on June 26, 2024

/close

from must-gather.

openshift-ci avatar openshift-ci commented on June 26, 2024

@sferich888: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from must-gather.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.