Giter VIP home page Giter VIP logo

Comments (6)

tomhughes avatar tomhughes commented on June 1, 2024

Yes, we've upgraded bootstrap to 5.1 which comes with some style changes.

Is this causing you some sort of problem?

from openstreetmap-website.

Dimitar5555 avatar Dimitar5555 commented on June 1, 2024

It is the first thing that catches my eye when I look at the screen (specifically middle left part where most of the editing happens in iD). I wouldn't call it a problem but it's annoying.

from openstreetmap-website.

tomhughes avatar tomhughes commented on June 1, 2024

I just assumed it was expected but it does look like it's an error. The root cause is

which @gravitystorm said was copied from bootstrap but bootstrap actually has it as one pixel not two.

from openstreetmap-website.

tomhughes avatar tomhughes commented on June 1, 2024

The same is true with the radius on the next line which is actually .25rem in the bootstrap stylesheet.

from openstreetmap-website.

gravitystorm avatar gravitystorm commented on June 1, 2024

Oh phooey, those were values I was using for debugging - I've copied the wrong ones into the PR.

Either they can be fixed immediately by updating parameters.scss, or alternatively #4261 can be merged, which upgrades to 5.2 and removes these overrides entirely.

from openstreetmap-website.

gravitystorm avatar gravitystorm commented on June 1, 2024

Yes, we've upgraded bootstrap to 5.1 which comes with some style changes.

We've been using 5.1 for a long time, the recent PR switched the scss compilation engine without changing bootstrap version. But that PR included the wrong values for these two settings, as part of a workaround for a different issue. I didn't notice because I was focussed on viewing the 5.2 and 5.3 PRs to check for any visual changes in those PRs.

Sorry for this!

from openstreetmap-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.