Comments (6)
Yes, we've upgraded bootstrap to 5.1 which comes with some style changes.
Is this causing you some sort of problem?
from openstreetmap-website.
It is the first thing that catches my eye when I look at the screen (specifically middle left part where most of the editing happens in iD). I wouldn't call it a problem but it's annoying.
from openstreetmap-website.
I just assumed it was expected but it does look like it's an error. The root cause is
which @gravitystorm said was copied from bootstrap but bootstrap actually has it as one pixel not two.from openstreetmap-website.
The same is true with the radius on the next line which is actually .25rem
in the bootstrap stylesheet.
from openstreetmap-website.
Oh phooey, those were values I was using for debugging - I've copied the wrong ones into the PR.
Either they can be fixed immediately by updating parameters.scss, or alternatively #4261 can be merged, which upgrades to 5.2 and removes these overrides entirely.
from openstreetmap-website.
Yes, we've upgraded bootstrap to 5.1 which comes with some style changes.
We've been using 5.1 for a long time, the recent PR switched the scss compilation engine without changing bootstrap version. But that PR included the wrong values for these two settings, as part of a workaround for a different issue. I didn't notice because I was focussed on viewing the 5.2 and 5.3 PRs to check for any visual changes in those PRs.
Sorry for this!
from openstreetmap-website.
Related Issues (20)
- Mobile: Edit button hidden HOT 2
- Why i am blocked by Fizzie41 in OpenStreetMap HOT 2
- Rename the "Add a note to the map button" to "Report an error on map" HOT 5
- Move code to GitLab or Codeberg HOT 2
- old user preferences containing "%" break PUT on /api/0.6/user/preferences HOT 6
- Dead Link on /copyright page HOT 3
- Trim username/e-mail whitespace in login page HOT 4
- Password field is not compared to repeat password field in Signup form HOT 9
- Comment vs. Subscribe on diary posts HOT 4
- Display authenticatoin-related timestamps on Oauth2 tab HOT 4
- Super-relations only render red line for way members (not relations) in search results HOT 2
- Remove help.openstreetmap.org from /help HOT 1
- History navigation inconsistent HOT 4
- Add Home Location privacy notice
- Proposal for Messages API HOT 8
- Disable boundaries in iD by default HOT 5
- Puntuaction and orthorgraphy in the website HOT 3
- Missing en translation: community.uk-london-mastodon.name HOT 3
- Add OAuth 1.0a deprecation warning to authorize.erb.html HOT 1
- Validation for note transitions HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openstreetmap-website.