LuCI status pages trigger infinite redirect about luci-commotion HOT 9 CLOSED

By infinite redirect do you mean a looping set of redirects or that it stalls?

from luci-commotion.

He means that the browser is giving the error "The page isn't redirecting properly. Firefox has detected that the server is redirecting the request for this address in a way that will never complete."

from luci-commotion.

Indeed.

from luci-commotion.

Ahhh, might be an error in how the https redirect in the header is parsing and then redirecting the current page. It should just change the http to https, but it might be cutting out the wrong part.

from luci-commotion.

Now that I've gotten a chance to look at it, it looks like you were right @elationfoundation. The crypto.check_https function loops forever, though it isn't because it cuts out the wrong part of the string. It looks like the environment no longer passes an HTTPS element, which is how the function previously determined that the redirect completed. I can change it to a env.SERVER_PORT ~= 443 check to 'fix' it, but that's kind of crappy. It's probably fine for our setup, but I don't like that it doesn't actually directly signal whether the handshake completed or not (if we were running HTTP on port 443 it would still complete). Not a big deal, but anyone have any better ideas about how to do that check?

from luci-commotion.

Looking at the source of uhttpd2, it looks like it could easily be patched to provide that env var. How would you feel about that? It would be a good opportunity to upstream it as well.

from luci-commotion.

I think we can submit an upstream patch, but I'm just going to make the SERVER_PORT change for now. It works for our setup, and it won't require that we patch or otherwise host our own uhttpd2 package. However, we can still submit it as an upstream issue, as I think it's a worthwhile addition, and switch back if it gets integrated.

from luci-commotion.

fixed by #448.

from luci-commotion.

uhttpd2 patch was submitted upstream. For reference: dismantl/uhttpd2@ac93428

from luci-commotion.