Comments (5)
yurishkuro
commented on June 26, 2024
it's a leftover from previous API. Operation name is a required first argument.
from opentracing-javascript.
bhs
commented on June 26, 2024
@robsimmons thanks for bringing this up. Let me know if my PR clarifies things sufficiently.
from opentracing-javascript.
robsimmons
commented on June 26, 2024
Is Span.setOperationName similarly deprecated, and does it similarly act to override the previously given name?
from opentracing-javascript.
yurishkuro
commented on June 26, 2024
it is not deprecated, on the contrary. There are cases when the correct span name is not available at the time of span creation, for example when the span is started by a generic instrumentation in some http framework, where the best that instrumentation can do is to call the span GET or POST, but once the control gets to the real business handler it can override it with something more meaningful like "getCustomerAddress".
from opentracing-javascript.
robsimmons
commented on June 26, 2024
Makes sense! Thanks for clarifying.
from opentracing-javascript.
Related Issues (20)
- MockTracer._allocSpan is private and can't be overwritten HOT 2
- Why not use interfaces instead of classes? HOT 13
- automatic tracer HOT 2
- Inject and Extract with BINARY format HOT 2
- [Feature Request] forEachBaggageItems on SpanContext
- Default import is not working in some contexts HOT 7
- Left me hanging - "the case where..."
- Trace should provide a method to get active span like other language API does
- Consider marking Span.constructor protected
- Is this project dead? HOT 1
- `__esModule` is `true` while no default export provided, breaks interoperability HOT 2
- trace should expose close function HOT 1
- SpanContext should expose a proper traceId and spanId
- How do I trace requests from the browser? HOT 4
- MockTracer does not allow testing tags
- How to I chain traces over more than two processes? HOT 13
- Type checks won't always work in Reference creating functions HOT 3
- Span tag values should be `string`s, `boolean`s or `number`s HOT 2
- After latest release we have blocker issue HOT 11
- Set a span parent without using the context
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentracing-javascript.