Comments (7)
I think if the Makefile
becomes a maintenance headache, then sure, let's get rid of it. If it's not a burden, then it may be nice for developers who don't work exclusively in JavaScript. Makefiles are not the greatest, but "most" developers have come across one at some time or another whereas npm
can be a little mysterious for those new-ish to node. Of course, I don't have any numbers to back up that statement, so weight it appropriately :)
Either way, I don't feel too strongly about it, but have a slight preference towards keeping it if it's not a pain to do so.
...
(Somewhat off-topic, I'm pretty sure that Git for Windows does install make by default. Or at least I don't recall having to do anything special beyond that to get make on my Windows system.)
from opentracing-javascript.
I am familiar with make but still found it confusing what I had to update to add the TS support for the normal build and webpack. It seems overkill to me.
You are probably right that make is more familiar for people who never used Node, but imo a javascript implementation should use what javascript developers know, not non-javascript developers ;) Of course the scripts should be documented in the readme.
Afaik make is only in MinGW, not in msysgit. But npm is always available.
from opentracing-javascript.
I don't feel strongly. If the Makefile is removed in the TS conversion, I won't complain :)
from opentracing-javascript.
+1 to remove Makefile, if possible. For people new to JS ecosystem we just need a few instructions in the Contributing file.
from opentracing-javascript.
I'm down to replace it will a small set of scripts and instructions.
from opentracing-javascript.
Can this issue now be closed?
from opentracing-javascript.
+1
from opentracing-javascript.
Related Issues (20)
- MockTracer._allocSpan is private and can't be overwritten HOT 2
- Why not use interfaces instead of classes? HOT 13
- automatic tracer HOT 2
- Inject and Extract with BINARY format HOT 2
- [Feature Request] forEachBaggageItems on SpanContext
- Default import is not working in some contexts HOT 7
- Left me hanging - "the case where..."
- Trace should provide a method to get active span like other language API does
- Consider marking Span.constructor protected
- Is this project dead? HOT 1
- `__esModule` is `true` while no default export provided, breaks interoperability HOT 2
- trace should expose close function HOT 1
- SpanContext should expose a proper traceId and spanId
- How do I trace requests from the browser? HOT 4
- MockTracer does not allow testing tags
- How to I chain traces over more than two processes? HOT 13
- Type checks won't always work in Reference creating functions HOT 3
- Span tag values should be `string`s, `boolean`s or `number`s HOT 2
- After latest release we have blocker issue HOT 11
- Set a span parent without using the context
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentracing-javascript.