Giter VIP home page Giter VIP logo

Comments (7)

bcronin avatar bcronin commented on June 26, 2024

I think if the Makefile becomes a maintenance headache, then sure, let's get rid of it. If it's not a burden, then it may be nice for developers who don't work exclusively in JavaScript. Makefiles are not the greatest, but "most" developers have come across one at some time or another whereas npm can be a little mysterious for those new-ish to node. Of course, I don't have any numbers to back up that statement, so weight it appropriately :)

Either way, I don't feel too strongly about it, but have a slight preference towards keeping it if it's not a pain to do so.

...

(Somewhat off-topic, I'm pretty sure that Git for Windows does install make by default. Or at least I don't recall having to do anything special beyond that to get make on my Windows system.)

from opentracing-javascript.

felixfbecker avatar felixfbecker commented on June 26, 2024

I am familiar with make but still found it confusing what I had to update to add the TS support for the normal build and webpack. It seems overkill to me.

You are probably right that make is more familiar for people who never used Node, but imo a javascript implementation should use what javascript developers know, not non-javascript developers ;) Of course the scripts should be documented in the readme.

Afaik make is only in MinGW, not in msysgit. But npm is always available.

from opentracing-javascript.

bcronin avatar bcronin commented on June 26, 2024

I don't feel strongly. If the Makefile is removed in the TS conversion, I won't complain :)

from opentracing-javascript.

yurishkuro avatar yurishkuro commented on June 26, 2024

+1 to remove Makefile, if possible. For people new to JS ecosystem we just need a few instructions in the Contributing file.

from opentracing-javascript.

tedsuo avatar tedsuo commented on June 26, 2024

I'm down to replace it will a small set of scripts and instructions.

from opentracing-javascript.

MarckK avatar MarckK commented on June 26, 2024

Can this issue now be closed?

from opentracing-javascript.

yurishkuro avatar yurishkuro commented on June 26, 2024

+1

from opentracing-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.