Giter VIP home page Giter VIP logo

Comments (6)

umed avatar umed commented on May 20, 2024

it's known security issue. We can update instruction and mention this issue and add that user can add himself to docker group on non-production systems, but has to run build scripts by using sudo on the systems where he is not in the docker group. Is it fine?

from dockerfiles.

xwu2git avatar xwu2git commented on May 20, 2024

We use cmake to build. Use sudo to run cmake? That will mess up with a lot of stuff.
I think we need to write instructions separately for Ubuntu and CentOS if needed, but do need to cover both host OS'es.

from dockerfiles.

xwu2git avatar xwu2git commented on May 20, 2024

Reread the article. I do think having sudo back is a better security measure.
Let's not suggest practices that have known security issues.

from dockerfiles.

umed avatar umed commented on May 20, 2024

@xwu2git we can revert changes for now then

from dockerfiles.

xwu2git avatar xwu2git commented on May 20, 2024

please do.

from dockerfiles.

dpatel257 avatar dpatel257 commented on May 20, 2024

Reverted on 'master'

from dockerfiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.