build-complete may remove all /tmp contents about openvpn-build HOT 6 CLOSED

Good catch. We should definitely document this and maybe even verify that TMPDIR is not set to /tmp. Care to provide a PR?

from openvpn-build.

I recall erasing my home directory when pointing TMPDIR to it

from openvpn-build.

I guess the best approach would be

1. create tmp dir from scratch
2. stop build if TMPDIR already exists

from openvpn-build.

@chipitsine wouldn't that mean that user would have to wipe TMPDIR manually before every build?

Perhaps, instead of wiping the TMPDIR entirely in build-complete, we could only wipe the build directories inside it. So, even if TMPDIR was /home/ or /tmp there would be no/minimal damage.

from openvpn-build.

I did have a backup of home dir, so I did not worry much :)

from openvpn-build.

@mattock: checking that TMPDIR isn't set to /tmp is the wrong way to do it, in my opinion because the default value for TMPDIR in many systems is /tmp (according to wikipedia).

What I would suggest is:

1. do not remove the temporary build directory at all
2. create a randomly-named temporary directory at each invocation.

My reasoning is:

• It's counter-intuitive to have a script called build which actually deletes things.
• The user may actually want to keep previous build artifacts.
• It's the OS responsibility to make sure /tmp has enough space, and the OS has a right to delete anything in /tmp anyway.
• Even if it was this script's responsibility to clean after itself, the way it does it now is not working: it only cleans up when invoked once again.

What do you think?

from openvpn-build.