Giter VIP home page Giter VIP logo

Comments (3)

pkohl avatar pkohl commented on August 30, 2024

If it doesn't break a bunch of things and isn't too hard to do, I'd be in favor of the change. The SI symbol for the ampere is A (it's one of the seven SI base units), and I agree that it is much more likely for end users to mean ampere than angstrom if they put in that symbol.

That said, it's also not that hard to work around if changing the symbol would break things.

from pg.

duffee avatar duffee commented on August 30, 2024

I also think A should stand for ampere.

The only references to Angstroms in the OPL are help files:

  • OpenProblemLibrary/macros/FortLewis/AnswerFormatHelp.pl
  • OpenProblemLibrary/Michigan/units.html

The question is whether you want a gradual transition or you like the Big Bang approach.

Either way, the first step is to add the new unit for Angstrom to Units.pm so that the help files in WW and OPL can be updated when the new unit is available in production.

I've just opened PR #753 to add some new units. The new angstrom could be added to that PR for convenience or separated out in its own PR for faster merging to main.

from pg.

pstaabp avatar pstaabp commented on August 30, 2024

We've merged in some changes (listed above) to handle angstroms.

from pg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.