Giter VIP home page Giter VIP logo

Comments (5)

GMNGeoffrey avatar GMNGeoffrey commented on June 2, 2024

I think the fundamental issue here is that visibility is almost useless outside of a monorepo. We also have to build our integration with TF with --nocheck_visibility (related, bazelbuild/bazel#16767)

from xla.

hawkinsp avatar hawkinsp commented on June 2, 2024

I think it's still useful to have visibility within each repository, e.g., for internal structuring purposes. The key is that we should open visibility to any public targets that cross repository boundaries.

from xla.

GMNGeoffrey avatar GMNGeoffrey commented on June 2, 2024

Right, it's nice intra-project but totally breaks across projects. Which is fine in google3 because it's all one "project". I think the concept of visibility groups is useful, but the implementation is totally not set up for a moderately complex constellation of projects

from xla.

hawkinsp avatar hawkinsp commented on June 2, 2024

Any updates? It's unfortunate to break visibility for all the downstream users and their own internals.

from xla.

tpopp avatar tpopp commented on June 2, 2024

As of, ccceb5f, this is resolved.

from xla.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.