Comments (4)
A question to ask is whether each role should have its own constructor argument, or if we add just one argument and reuse it for all roles. A third option could be to add one argument for the admin and a separate argument for all other roles.
If the address passed in is zero, the role shouldn't be granted.
from contracts-wizard.
This should also apply for owner if using Ownable.
from contracts-wizard.
This issue is important because if the contract is deployed using CREATE2
or via the "CREATE3" method, msg.sender
's value is the address of the factory contract or a temporary proxy contract, instead of the expected account initiating the deployment. Then the factory contract ends up owning the deployed contract and receiving initially minted tokens (that then may be stuck forever).
from contracts-wizard.
tx.origin
gives the expected value but Vitalik said it shouldn't be relied upon.
from contracts-wizard.
Related Issues (20)
- Download Hardhat development environment HOT 1
- Download Hardhat: add development network file to .gitignore HOT 7
- ERC721 safeMint should return the tokenId HOT 4
- Link readme image to wizard.openzeppelin.com HOT 2
- Update Cairo formatting
- Governor redundant overrides
- Highlight differences when changing features
- Consider adding Governor and Votes clock options
- Add html meta description for wizard.openzeppelin.com HOT 1
- Error: spawn yarn ENOENT
- NPM package has unspecified dependency on @openzeppelin/contracts
- Can't resolve '../openzeppelin-contracts' in `wizard` 0.2.2 HOT 2
- ERC20 Premint field has no upper bound
- Invalid contracts generated for @openzeppelin/contracts 4.9.0 HOT 1
- Use package entry points for core
- Enable ERC20Permit by default HOT 7
- Use token-specific pausable extensions HOT 1
- add required OpenZeppelin Contracts version as a comment ? HOT 1
- Copy to Clipboard not working from docs site HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contracts-wizard.